From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas Ruschival <thomas@ruschival.de>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 1/2] package/pistache: fix dependency on rapidjson
Date: Wed, 14 Sep 2022 11:46:51 +0200 [thread overview]
Message-ID: <87fsguqodw.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220804203555.29029-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni via buildroot's message of "Thu, 4 Aug 2022 22:35:53 +0200")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> rapidjson has been added as a dependency of pistache as part of commit
> 2f3218567953185008ec862f814bebecb9d6ed82 ("package/pistache: bump
> version & switch to meson build"), using a "depends on". However, as
> it is a library dependency, a "select" is normally used in Buildroot.
> rapidjson's only dependency is on C++ support, which is already a
> dependency of pistache.
> In addition, use = instead of += for the rapidjson dependency in the
> .mk file, as it's an unconditional dependency.
> Cc: Thomas Ruschival <thomas@ruschival.de>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-14 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 20:35 [Buildroot] [PATCH 1/2] package/pistache: fix dependency on rapidjson Thomas Petazzoni via buildroot
2022-08-04 20:35 ` [Buildroot] [PATCH 2/2] package/pistache: enable on uClibc Thomas Petazzoni via buildroot
2022-08-05 16:29 ` Yann E. MORIN
2022-08-06 13:45 ` Thomas Petazzoni via buildroot
2022-08-06 14:15 ` Yann E. MORIN
2022-08-05 16:29 ` [Buildroot] [PATCH 1/2] package/pistache: fix dependency on rapidjson Yann E. MORIN
2022-09-14 9:46 ` Peter Korsgaard [this message]
2022-09-14 9:47 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsguqodw.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas@ruschival.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox