Re: [Buildroot] [PATCH v2 1/2] support/scripts/pkg-stats: move to procedurally generated row/column clases

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Fri,  5 Aug 2022 15:01:13 -0500
Sen Hastings <sen@phobosdpl.com> wrote:

> Rather than having pre-baked classes in the markup for sorting purposes,
> all the cells in package-grid are iterated over at load time and given
> a row/column class.
> 
> example: https://sen-h.github.io/pkg-stats/b6f4cbddb14233c3ab3fdfea1e486c14871cfb2a.html
> 
> Signed-off-by: Sen Hastings <sen@phobosdpl.com>

I am probably not versed enough into HTML/CSS/JS sorcery, but I don't
understand the benefit of this. Could you explain a bit more?

>  function sortGrid(sortLabel){
>  	let i = 0;
>  	let pkgSortArray = [], sortedPkgArray = [], pkgStringSortArray = [], pkgNumSortArray = [];
> @@ -774,14 +785,11 @@ function sortGrid(sortLabel){
>  	const styleSheet = styleElement.sheet;
>  
>          columnValues.shift();
> -        columnValues.forEach((listing) => {
> +	columnValues.forEach((listing) => {

This is a spurious change.

>          if (fieldText == "see all " + fieldTotal + triangleDown){
> -		field.firstElementChild.innerText = "see less " + fieldTotal + triangleUp;
> +                field.firstElementChild.innerText = "see less " + fieldTotal + triangleUp;

This is also a spurious change.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot