Re: [Buildroot] [PATCH v1 2/2] support/scripts/pkg-stats: optimize CSS selector usage

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Sen,

On Fri,  5 Aug 2022 15:01:14 -0500
Sen Hastings <sen@phobosdpl.com> wrote:

> Having lots of CSS selector declarations adds up, especially at 70k+
> elements.
> 
> This reduces the number of CSS selectors printed in the markup
> to the bare minimum, by using pseudo-classes and tag names as selectors.

Not sure how this works. Is there a significant size benefit? Sometimes
having a dumb but obvious solution is better than having a smart but
convoluted solution.

> +div {
> +  text-align: center;
> +  border: solid 1px gray;
> +}
> +#results-grid div{
> +  text-align: left;
> +}
> +#package-grid div:nth-child(13n+1), #package-grid div:nth-child(13n+13)  {
> +  text-align: left;
> +}
> +#package-grid div:nth-child(13){
> +  text-align: center;

What is this 13 magic number?

Also, unrelated to this, when I look at the currently generated HTML,
it looks odd. I see things like this:

  <div id="upstream_url__package_kodi-audiodecoder-vgmstream_kodi-audiodecoder-vgmstream" class="centered upstream_url data _package_kodi-audiodecoder-vgmstream_kodi-audiodecoder-vgmstream good_url"><a href="https://github.com/xbmc/audiodecoder.vgmstream">Link</a></div>

Why do we have these crazy id values now? why does the class property
contain a value such as
_package_kodi-audiodecoder-vgmstream_kodi-audiodecoder-vgmstream?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot