[Buildroot] [PATCH] pine64_sopine_defconfig: Use mainline ATF

[Buildroot] [PATCH] pine64_sopine_defconfig: Use mainline ATF

[Alistair Francis]

Use the mainline ATF as it supports the Pine64 SoPine module.

Signed-off-by: Alistair Francis <alistair@alistair23.me>
---
 configs/pine64_sopine_defconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/configs/pine64_sopine_defconfig b/configs/pine64_sopine_defconfig
index 6fa511477c..2295c9338d 100644
--- a/configs/pine64_sopine_defconfig
+++ b/configs/pine64_sopine_defconfig
@@ -7,10 +7,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_0=y
 
 # Firmware
 BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
-BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
-BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/apritzel/arm-trusted-firmware.git"
-BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50iw1p1"
-BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="aa75c8da415158a94b82a430b2b40000778e851f"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
 
 # Bootloader
-- 
2.37.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] pine64_sopine_defconfig: Use mainline ATF

[Thomas Petazzoni via buildroot]

Hello Francis,

On Tue,  9 Aug 2022 21:33:29 +1000
Alistair Francis <alistair@alistair23.me> wrote:

> Use the mainline ATF as it supports the Pine64 SoPine module.
> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
>  configs/pine64_sopine_defconfig | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/configs/pine64_sopine_defconfig b/configs/pine64_sopine_defconfig
> index 6fa511477c..2295c9338d 100644
> --- a/configs/pine64_sopine_defconfig
> +++ b/configs/pine64_sopine_defconfig
> @@ -7,10 +7,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_0=y
>  
>  # Firmware
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_URL="https://github.com/apritzel/arm-trusted-firmware.git"
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50iw1p1"
> -BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_REPO_VERSION="aa75c8da415158a94b82a430b2b40000778e851f"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
>  BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y

Thanks a lot! However, could you adjust the patch to use a fixed
version of ATF, like is done for Linux or U-Boot in all our defconfigs?

Also, do you confirm this change was tested on hardware? Does it solve
https://gitlab.com/buildroot.org/buildroot/-/jobs/2812053812 ? If yes,
then could you include something like this in your commit log:

Fixes:

  https://gitlab.com/buildroot.org/buildroot/-/jobs/2812053812

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot