Re: [Buildroot] [PATCH v2, 1/1] package/poppler: fix introspection build

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Olivier Schonken <olivier.schonken@gmail.com>,
	Adam Duskett <aduskett@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/poppler: fix introspection build
Date: Sun, 14 Aug 2022 12:37:48 +0200	[thread overview]
Message-ID: <20220814123748.167ebb02@windsurf> (raw)
In-Reply-To: <20220812101718.47491-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

+Adam Duskett for GOI expertise.

On Fri, 12 Aug 2022 12:17:18 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> diff --git a/package/poppler/poppler.mk b/package/poppler/poppler.mk
> index b54262e7c4..db6da25d39 100644
> --- a/package/poppler/poppler.mk
> +++ b/package/poppler/poppler.mk
> @@ -47,7 +47,8 @@ POPPLER_DEPENDENCIES += gobject-introspection
>  POPPLER_CONF_OPTS += \
>  	-DENABLE_GOBJECT_INTROSPECTION=ON \
>  	-DINTROSPECTION_SCANNER=$(STAGING_DIR)/usr/bin/g-ir-scanner \
> -	-DINTROSPECTION_COMPILER=$(STAGING_DIR)/usr/bin/g-ir-compiler
> +	-DINTROSPECTION_COMPILER=$(STAGING_DIR)/usr/bin/g-ir-compiler \
> +	-DINTROSPECTION_COMPILER_ARGS="--includedir=$(STAGING_DIR)/usr/share/gir-1.0"
>  else
>  POPPLER_CONF_OPTS += -DENABLE_GOBJECT_INTROSPECTION=OFF
>  endif

I am really not familiar with all the gobject-introspection stuff, but
I'm wondering if this is the right solution for this problem.

In package/gobject-introspection/, I can see that we create and install
a g-ir-scanner wrapper that passes --add-include-path="$(dirname
"$0")"/../share/gir-1.0.

In this same directory, we also have a g-ir-compiler wrapper, which is
used to execute things in Qemu. If a special path is needed, why don't
we pass it within this wrapper, so that the solution works for all
packages?

Apparently, according to
package/libglib2/0004-meson.build-add-girdir-to-gio-2.0.pc-and-glib-2.0.pc.patch
there are some packages that set girdir in their .pc file so that other
packages now where to find the GIR files.

Really not clear in my mind how all of this should work. My only
concern is that I would like us to find and use the same solution
everywhere to solve the same problem, rather than having 10 different
solutions for each package encountering the same issue.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot