Re: [Buildroot] [PATCH v2, 1/1] package/poppler: fix introspection build

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Olivier Schonken <olivier.schonken@gmail.com>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	Adam Duskett <aduskett@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/poppler: fix introspection build
Date: Tue, 18 Apr 2023 19:44:52 +0200	[thread overview]
Message-ID: <20230418174452.GP2819@scaer> (raw)
In-Reply-To: <CADvTj4q-qJ6EiYxOcNfgQRL1q7UPNp9SC7s_CwBVeCk=6PrMqw@mail.gmail.com>

James, All,

On 2023-04-18 02:03 -0600, James Hilliard spake thusly:
> On Sun, Apr 16, 2023 at 5:17 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2023-04-16 10:25 +0200, Yann E. MORIN spake thusly:
> > > On 2023-04-15 20:44 -0600, James Hilliard spake thusly:
> > > > On Sat, Apr 15, 2023 at 3:30 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > > [--SNIP--]
> > > > > However, I would really like to understand why we don't have more
> > > > > packages that are broken. Is it because poppler is the only one with
> > > > > include directives in his gir file, which means it needs access to the
> > > > > installed gir files from other packages (those from goi)?
> > > > >
> > > > > Or is it because it is the only one that already passes an explicit
> > > > > --includedir option to g-ir-compiler, and that disables searching the
> > > > > standard directory?
> > > > From the looks of it most of our packages with a gobject-introspection
> > > > dependency are meson based which use the native meson integration.
> > > Ah, good point, that would explain.
> > Unfortuantely, that assumption is wrong: granite uses meson, but fails
> > in the same way:
> While it's true it does use meson...it does not in fact use the native meson
> integration but rather uses a project specific gobject-introspection generator:
> https://github.com/elementary/granite/blob/6.0.0/lib/meson.build#L102-L121

Sure, but then maybe it begs for a generic solution, that works for all
packages?

Maybe something like we used GIR_EXTRA_LIBS_PATH from the environment,
we could allow paclages to specify additional include directories with
GIR_EXTRA_INCLUDE_PATH ?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot