[Buildroot] [PATCH 1/1] package/makedumpfile: set CROSS

[Buildroot] [PATCH 1/1] package/makedumpfile: set CROSS

[Fabrice Fontaine]

Set CROSS variable otherwise makedumpfile will use it to undefine the
host architecture through -U__$(HOST_ARCH)__ if $(TARGET) is not equal
to $(HOST_ARCH). This will result in the following build failure since
the addition of the package in commit
adb64a97e79bcb4e28450dd858654003ec8706c3 if aarch64_be is cross-compiled
on a aarch64 host for example:

/home/autobuild/autobuild/instance-5/output-1/host/bin/aarch64_be-buildroot-linux-uclibc-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O3 -g0  -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DVERSION='"1.7.0"' -DRELEASE_DATE='"8 Nov 2021"' -D__aarch64_be__ -U__aarch64__ -DUSELZO -c -o ./print_info.o print_info.c

[...]

makedumpfile.c: In function 'is_kvaddr':
makedumpfile.c:1547:46: error: 'KVBASE' undeclared (first use in this function)
 1547 |         return (addr >= (unsigned long long)(KVBASE));
      |                                              ^~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/e4e10364e1a24099ce31bf20eacf5adedf93e5a7

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/makedumpfile/makedumpfile.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/makedumpfile/makedumpfile.mk b/package/makedumpfile/makedumpfile.mk
index 8399e4d063..815a159b00 100644
--- a/package/makedumpfile/makedumpfile.mk
+++ b/package/makedumpfile/makedumpfile.mk
@@ -17,6 +17,7 @@ MAKEDUMPFILE_TARGET = $(BR2_ARCH)
 endif
 
 MAKEDUMPFILE_MAKE_OPTS = \
+	CROSS= \
 	TARGET=$(MAKEDUMPFILE_TARGET) \
 	LINKTYPE=dynamic
 
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/makedumpfile: set CROSS

[Thomas Petazzoni via buildroot]

On Mon, 15 Aug 2022 11:40:54 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Set CROSS variable otherwise makedumpfile will use it to undefine the
> host architecture through -U__$(HOST_ARCH)__ if $(TARGET) is not equal
> to $(HOST_ARCH). This will result in the following build failure since
> the addition of the package in commit
> adb64a97e79bcb4e28450dd858654003ec8706c3 if aarch64_be is cross-compiled
> on a aarch64 host for example:
> 
> /home/autobuild/autobuild/instance-5/output-1/host/bin/aarch64_be-buildroot-linux-uclibc-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O3 -g0  -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DVERSION='"1.7.0"' -DRELEASE_DATE='"8 Nov 2021"' -D__aarch64_be__ -U__aarch64__ -DUSELZO -c -o ./print_info.o print_info.c
> 
> [...]
> 
> makedumpfile.c: In function 'is_kvaddr':
> makedumpfile.c:1547:46: error: 'KVBASE' undeclared (first use in this function)
>  1547 |         return (addr >= (unsigned long long)(KVBASE));
>       |                                              ^~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e4e10364e1a24099ce31bf20eacf5adedf93e5a7
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/makedumpfile/makedumpfile.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/makedumpfile: set CROSS

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Set CROSS variable otherwise makedumpfile will use it to undefine the
 > host architecture through -U__$(HOST_ARCH)__ if $(TARGET) is not equal
 > to $(HOST_ARCH). This will result in the following build failure since
 > the addition of the package in commit
 > adb64a97e79bcb4e28450dd858654003ec8706c3 if aarch64_be is cross-compiled
 > on a aarch64 host for example:

 > /home/autobuild/autobuild/instance-5/output-1/host/bin/aarch64_be-buildroot-linux-uclibc-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O3 -g0  -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DVERSION='"1.7.0"' -DRELEASE_DATE='"8 Nov 2021"' -D__aarch64_be__ -U__aarch64__ -DUSELZO -c -o ./print_info.o print_info.c

 > [...]

 > makedumpfile.c: In function 'is_kvaddr':
 > makedumpfile.c:1547:46: error: 'KVBASE' undeclared (first use in this function)
 >  1547 |         return (addr >= (unsigned long long)(KVBASE));
 >       |                                              ^~~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/e4e10364e1a24099ce31bf20eacf5adedf93e5a7

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot