Re: [Buildroot] [PATCH] package/forge: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Johan, All,

Sorry for the late review...

On 2022-03-22 17:07 +0100, Johan Oudinet spake thusly:
> A native implementation of TLS (and various other cryptographic tools)
> in JavaScript.

I see that you used the npm registry as the source for this package. So,
I'd expect it to be an nodejs package, right? If so, then it should
probably depend on nodejs being enabled.

Also, why do we need to get the package from the npm registry, instead
of from the upstream git tree?

> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
[--SNIP--]
> diff --git a/package/forge/Config.in b/package/forge/Config.in
> new file mode 100644
> index 0000000000..86d4832101
> --- /dev/null
> +++ b/package/forge/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_FORGE
> +	bool "forge"

Here, I would have expected:

    depends on BR2_PACKAGE_NODEJS

> +	help
> +	  A native implementation of TLS (and various other
> +	  cryptographic tools) in JavaScript.
> +
> +	  https://github.com/digitalbazaar/forge
[--SNIP--]
> diff --git a/package/forge/forge.mk b/package/forge/forge.mk
> new file mode 100644
> index 0000000000..1872cb4e70
> --- /dev/null
> +++ b/package/forge/forge.mk
> @@ -0,0 +1,23 @@
> +################################################################################
> +#
> +# forge
> +#
> +################################################################################
> +
> +FORGE_VERSION = 1.3.0
> +FORGE_SOURCE = node-forge-$(FORGE_VERSION).tgz
> +FORGE_SITE = https://registry.npmjs.org/node-forge/-
> +FORGE_LICENSE = BSD-3-Clause, GPL-2.0
> +FORGE_LICENSE_FILES = LICENSE
> +
> +# Install .min.js as .js
> +define FORGE_INSTALL_TARGET_CMDS
> +	$(INSTALL) -m 644 -D $(@D)/dist/forge.all.min.js \
> +		$(TARGET_DIR)/var/www/forge.all.js
> +	$(INSTALL) -m 644 -D $(@D)/dist/forge.min.js \
> +		$(TARGET_DIR)/var/www/forge.js
> +	$(INSTALL) -m 644 -D $(@D)/dist/prime.worker.min.js \
> +		$(TARGET_DIR)/var/www/prime.worker.js
> +endef

So, I think I now see why you grabbed the package from the npm registry:
the package has been built and the minified files generated.

I'm afraid that I do not like that very much.

Instead, you should grab the sources from th github repo, have the
package depend on host-nodejes, and build the pacakge with $(NPM) build.

Regards,
Yann E. MORIN.

> +$(eval $(generic-package))
> -- 
> 2.32.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot