Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Johan Oudinet <johan.oudinet@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/forge: new package
Date: Sun, 28 Aug 2022 10:06:05 +0200	[thread overview]
Message-ID: <20220828100605.509b1ead@windsurf> (raw)
In-Reply-To: <20220827084732.GR37358@scaer>

Hello,

On Sat, 27 Aug 2022 10:47:32 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> > +FORGE_VERSION = 1.3.1
> > +FORGE_SITE = $(call github,digitalbazaar,forge,v$(FORGE_VERSION))
> > +FORGE_LICENSE = BSD-3-Clause, GPL-2.0
> > +FORGE_LICENSE_FILES = LICENSE
> > +
> > +FORGE_DEPENDENCIES = host-nodejs
> > +
> > +define FORGE_BUILD_CMDS
> > +	cd $(@D) && $(NPM) install && $(NPM) run build  
> 
> So we have to install before we can build? I would have expected the
> other way around... I have (almost) zero experience with npm, so I am
> not sure about the semantics of 'install' vs. 'build'.
> 
> Also, where does 'install' installs things?

And side questions are:

 - Does this $(NPM) install step downloads stuff? If it does, then it's
   wrong, because it works around Buildroot's download infrastructure.

 - Does this $(NPM) install step installs extra stuff? If it does, are
   these extra things accounted for from a legal information
   perspective?

Yeah, I know, annoying questions :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-08-28  8:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 16:07 [Buildroot] [PATCH] package/forge: new package Johan Oudinet
2022-08-22 14:12 ` Yann E. MORIN
2022-08-26 14:11   ` Johan Oudinet
2022-08-26 21:07     ` Yann E. MORIN
2022-08-26 13:08 ` [Buildroot] [PATCH v2] " Johan Oudinet
2022-08-27  8:47   ` Yann E. MORIN
2022-08-28  8:06     ` Thomas Petazzoni via buildroot [this message]
2022-08-28  8:35       ` Yann E. MORIN
2022-09-01 15:43         ` Johan Oudinet
2022-09-24 15:05   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220828100605.509b1ead@windsurf \
    --to=buildroot@buildroot.org \
    --cc=johan.oudinet@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox