Re: [Buildroot] [PATCH 1/1] package/openlayers: bump to version 7.0.0

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Claveirole <thomas.claveirole@green-communications.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/openlayers: bump to version 7.0.0
Date: Sat, 27 Aug 2022 11:36:03 +0200	[thread overview]
Message-ID: <20220827093603.GT37358@scaer> (raw)
In-Reply-To: <20220825151204.390615-1-thomas.claveirole@green-communications.fr>

Thomas, All,

On 2022-08-25 17:12 +0200, Thomas Claveirole spake thusly:
> Do not rely on the "dist" archive anymore (or the "legacy" archive as
> OpenLayers calls it now).  Build the JavaScript directly from the
> source archive instead, using host-nodejs.

Ah, another case [0] of building sith host-nodejs, two data-points,
better than one! :-) And see below [1]...

[0] https://lore.kernel.org/buildroot/20220827084732.GR37358@scaer/T/#m4c898e32584721ce8a793bedc6a057dff98cbf3e

> Note that the v6.14.1-dist.zip archive for the previous version did
> change, hence the hash for previous version is broken.  See
> https://github.com/openlayers/openlayers/issues/14053 for details.

Ah, this is bad... :-( "First rule of release management: do not ever
change a release."

So, for master: v6.14.1 is just a fix in the package-lock?json. Since
we were not building the package, but were relying on the pre-build
archive, we should not be imapcted by this change, right? In that case,
we could just revert back to using v6.14.0, so that we can have a hash
that is correct.

Thoughts?

> Signed-off-by: Thomas Claveirole <thomas.claveirole@green-communications.fr>
> ---
[--SNIP--]
> diff --git a/package/openlayers/openlayers.mk b/package/openlayers/openlayers.mk
> index 4626e7545a..08a58cd796 100644
> --- a/package/openlayers/openlayers.mk
> +++ b/package/openlayers/openlayers.mk
> @@ -4,21 +4,26 @@
>  #
>  ################################################################################
>  
> -OPENLAYERS_VERSION = 6.14.1
> -OPENLAYERS_SOURCE = v$(OPENLAYERS_VERSION)-dist.zip
> -OPENLAYERS_SITE = https://github.com/openlayers/openlayers/releases/download/v$(OPENLAYERS_VERSION)
> -OPENLAYERS_LICENSE = BSD-2-Clause
> -# There's no separate license file in the archive, only minified files.
> +OPENLAYERS_VERSION = 7.0.0
> +OPENLAYERS_SITE = $(call github,openlayers,openlayers,v$(OPENLAYERS_VERSION))
>  
> -define OPENLAYERS_EXTRACT_CMDS
> -	unzip $(OPENLAYERS_DL_DIR)/$(OPENLAYERS_SOURCE) -d $(@D)
> -	mv $(@D)/v$(OPENLAYERS_VERSION)-dist/* $(@D)
> -	rmdir $(@D)/v$(OPENLAYERS_VERSION)-dist/
> +# OpenLayers itself is BSD-2-Clause, but not all of the dependencies
> +# it brings in are.  See $(@D)/build/legacy/*.LICENSE.txt after build
> +# for details.
> +OPENLAYERS_LICENSE = BSD-2-Clause, BSD-3-Clause (ieee754), Apache-2.0
> +OPENLAYERS_LICENSE_FILES = LICENSE.md
> +
> +OPENLAYERS_DEPENDENCIES = host-nodejs
> +
> +define OPENLAYERS_BUILD_CMDS
> +	cd $(@D) && $(NPM) install && $(NPM) run build-legacy

[1] As I said in [0], it is weird to see that we need to install before
we can build?

Why build-legacy? a small note in the comit log to explain that would be
nice.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot