Re: [Buildroot] [PATCH 1/1] package/openlayers: bump to version 7.0.0

[Thomas Claveirole <thomas.claveirole@green-communications.fr>]

[-- Attachment #1.1: Type: text/plain, Size: 2377 bytes --]

> Ah, another case [0] of building sith host-nodejs, two data-points,
> better than one! :-) And see below [1]...

Yes, I actually work with Johan and he pointed these messages to me already.  
We also plan to use host-nodejs for the vuejs and vuejs-router packages when 
we find time for this...

... and, at this stage, I am thinking this would probably need a dedicated 
architecture.  Unfortunately I am not sure I know enough about Buildroot and 
npm to do this (I know next to nothing about npm, actually...)

> > Note that the v6.14.1-dist.zip archive for the previous version did
> > change, hence the hash for previous version is broken.  [...]
> 
> So, for master: v6.14.1 is just a fix in the package-lock?json. Since
> we were not building the package, but were relying on the pre-build
> archive, we should not be imapcted by this change, right? In that case,
> we could just revert back to using v6.14.0, so that we can have a hash
> that is correct.

I did not look into the details.  If package-lock.json is the only difference 
between v6.14.0 and v6.14.1, then yes, I agree.

> [1] As I said in [0], it is weird to see that we need to install before
> we can build?

npm install does **not** actually install anything into the target file 
system.  If I understood correctly, it just downloads the dependencies 
required to build the package, and installs them in ./node_modules, which is $
(@D)/node_modules in our cases.

This is according to npm -h:

npm <command>

Usage:

npm install        install all the dependencies in your project
npm install <foo>  add the <foo> dependency to your project
[...]

> Why build-legacy? a small note in the comit log to explain that would be
> nice.

The default build generates a lot of JavaScript modules that clients should 
load independently (if I understood correctly) and this is not what we want 
here.  We want a single JavaScript file to process without using modules, that 
will populate a global ol object ("namespace") with the library.  The other 
JavaScript packages that I know of in Buildroot (e.g., jquery, vuejs) work the 
same.

I need to make a new revision of this patch anyway (I will try to do it as 
soon as I can, sorry if I am a bit slow these days...)  So I will add a note 
when I do this.

Thanks for your remarks, cheers,
-- 
Thomas Claveirole <thomas.claveirole@green-communications.fr>

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot