Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc bug 90620

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Peter Seiderer <ps.report@gmx.net>,
	Julien Corjon <corjon.j@ecagroup.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org, Romain Naour <romain.naour@gmail.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc bug 90620
Date: Sun, 11 Sep 2022 21:30:46 +0200	[thread overview]
Message-ID: <20220911193046.GH898622@scaer> (raw)
In-Reply-To: <20220910135256.1689860-1-giulio.benetti@benettiengineering.com>

Giulio, All,

On 2022-09-10 15:52 +0200, Giulio Benetti spake thusly:
> Gcc bug 90620 reappeared with gcc 11.x so let's update
> BR2_TOOLCHAIN_HAS_GCC_BUG_90620 conditions.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  toolchain/Config.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index fbc2f28553..16e358344d 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -168,11 +168,12 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_85862
>  
>  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90620
>  # ICE: in do_output_reload, at reload1.c:7978 on microblaze.
> -# This bug no longer exists in gcc 10.x
> +# This bug no longer exists in gcc 10.x but reappeared in gcc 11.x
>  config BR2_TOOLCHAIN_HAS_GCC_BUG_90620
>  	bool
> -	default y if BR2_microblaze
> -	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_10
> +	default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_10
> +	default y if BR2_TOOLCHAIN_GCC_AT_LEAST_11
> +	depends on BR2_microblaze

I am not sure why the switch of default to depends is needed, because the
same condition can still be written without changing the default:

    default y if BR2_microblaze
    depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_10 \
            || BR2_TOOLCHAIN_GCC_AT_LEAST_11

Yeah, I see that other symbols that have a dependency on two gcc version
have the default/depends inverted, but symbols that have a dependency on
a single gcc version do not, e.g.:

    config BR2_TOOLCHAIN_HAS_GCC_BUG_85862
        bool
        default y if BR2_microblaze
        depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7

So, I think it is better to keep the same semantics between the two
situations.

So, I fixed that, and applied to master, thanks.

Note, there is also a third way to write it, and obviouslty we are also
using that:

    config BR2_TOOLCHAIN_HAS_GCC_BUG_93847
        bool
        default y if BR2_nios2 && !BR2_TOOLCHAIN_GCC_AT_LEAST_9

Meh... :-(

Note: this is *not* a plea for patches to fix that, at all. I just like
ranting a bit. ;-)

Regards,
Yann E. MORIN.

>  # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93847
>  # ICE: compiler error: Segmentation fault on Nios II. This bug
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot