From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Peter Seiderer <ps.report@gmx.net>,
Julien Corjon <corjon.j@ecagroup.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org, Romain Naour <romain.naour@gmail.com>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH 2/2] package/qt5/qt5xmlpatterns: fix build failure due to gcc bug 90620
Date: Sun, 11 Sep 2022 21:45:25 +0200 [thread overview]
Message-ID: <20220911194525.GI898622@scaer> (raw)
In-Reply-To: <20220910135256.1689860-2-giulio.benetti@benettiengineering.com>
Giulio, All,
On 2022-09-10 15:52 +0200, Giulio Benetti spake thusly:
> The qt5xmlpatterns package exhibits gcc bug 90620 when built for the
> Microblaze architecture with optimization enabled, which causes a build
> failure.
>
> As done for other packages in Buildroot work around this gcc bug by
> setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_90620=y like we
> already do for BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y.
I don't see the point of mentionning 85180 here, because it is not
already used for qt5xmlpatterns, or any other qt5 package, and there is
no reason to refer to it more than to e.g. 68485 that has the same
workaround. So I drop that part.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> Fixes:
> http://autobuild.buildroot.net/results/346/346e6d502a8927c8e95eea156f5b2943a85d0a6b/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk b/package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk
> index 3bb4ef74fd..6711e9bf70 100644
> --- a/package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk
> +++ b/package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk
> @@ -20,4 +20,8 @@ ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
> QT5XMLPATTERNS_LICENSE += , BSD-3-Clause (examples)
> endif
>
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_90620),y)
> +QT5XMLPATTERNS_CONF_OPTS += "QMAKE_CXXFLAGS+=-O0"
> +endif
> +
> $(eval $(qmake-package))
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-11 19:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 13:52 [Buildroot] [PATCH 1/2] toolchain/Config.in: update gcc bug 90620 Giulio Benetti
2022-09-10 13:52 ` [Buildroot] [PATCH 2/2] package/qt5/qt5xmlpatterns: fix build failure due to " Giulio Benetti
2022-09-11 19:45 ` Yann E. MORIN [this message]
2022-09-18 21:15 ` Peter Korsgaard
2022-09-11 19:30 ` [Buildroot] [PATCH 1/2] toolchain/Config.in: update " Yann E. MORIN
2022-09-11 19:43 ` Giulio Benetti
2022-09-11 19:54 ` Yann E. MORIN
2022-09-18 21:15 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220911194525.GI898622@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=corjon.j@ecagroup.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=ps.report@gmx.net \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox