Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Gwenhael Goavec-Merou <gwenj@trabucayre.com>
Cc: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/gnuradio: bump version to 3.10.3.0
Date: Sat, 17 Sep 2022 17:57:05 +0200	[thread overview]
Message-ID: <20220917175705.325903a1@windsurf> (raw)
In-Reply-To: <1663333463-55247-1-git-send-email-gwenj@trabucayre.com>

Hello,

On Fri, 16 Sep 2022 15:04:23 +0200
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:

> diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
> index 103175946c..fd693c1851 100644
> --- a/package/gnuradio/Config.in
> +++ b/package/gnuradio/Config.in
> @@ -15,19 +15,19 @@ config BR2_PACKAGE_GNURADIO
>  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>  	depends on BR2_USE_MMU # use fork()
>  	depends on BR2_USE_WCHAR # boost
> -	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic, boost-filesystem
> +	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic, boost-thread
>  	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_43744
>  	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-thread
>  	select BR2_PACKAGE_BOOST
>  	select BR2_PACKAGE_BOOST_ATOMIC
>  	select BR2_PACKAGE_BOOST_DATE_TIME
> -	select BR2_PACKAGE_BOOST_FILESYSTEM
>  	select BR2_PACKAGE_BOOST_PROGRAM_OPTIONS
>  	select BR2_PACKAGE_BOOST_REGEX
>  	select BR2_PACKAGE_BOOST_SYSTEM
>  	select BR2_PACKAGE_BOOST_THREAD
>  	select BR2_PACKAGE_LOG4CPP
>  	select BR2_PACKAGE_GMP
> +	select BR2_PACKAGE_SPDLOG
>  	select BR2_PACKAGE_VOLK
>  	help
>  	  GNU Radio is a free & open-source software development
> @@ -80,7 +80,8 @@ config BR2_PACKAGE_GNURADIO_PYTHON
>  	depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS
>  	depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL # python-numpy
>  	select BR2_PACKAGE_BOOST_PYTHON
> -	select BR2_PACKAGE_PYTHON_NUMPY # runtime
> +	select BR2_PACKAGE_PYTHON_NUMPY

Why are you removing the "# runtime" comment here? Your patch doesn't
change numpy to a build time dependency.

> +	select BR2_PACKAGE_PYTHON_PYBIND

The target pybind is a build time dependency?

> -# host-python-mako and host-python-six are needed for volk to compile
>  GNURADIO_DEPENDENCIES = \
>  	host-python3 \
> -	host-python-mako \
> -	host-python-six \
> -	host-swig \
>  	boost \
>  	log4cpp \
>  	gmp \
> +	spdlog \
>  	volk
>  
>  GNURADIO_CONF_OPTS = \
> @@ -115,7 +112,8 @@ GNURADIO_CONF_OPTS += -DENABLE_GR_FILTER=OFF
>  endif
>  
>  ifeq ($(BR2_PACKAGE_GNURADIO_PYTHON),y)
> -GNURADIO_DEPENDENCIES += python3
> +GNURADIO_DEPENDENCIES += python3 python-pybind \
> +	host-python-numpy host-python-packaging

Could you clarify if you need python-pybind on the target or on the
host? And also explain in the commit log why host-python-numpy and
host-python-packaging are now needed?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-09-17 15:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 13:04 [Buildroot] [PATCH v2] package/gnuradio: bump version to 3.10.3.0 Gwenhael Goavec-Merou
2022-09-17 15:57 ` Thomas Petazzoni [this message]
2022-09-23  8:40   ` Gwenhael Goavec-Merou
2022-09-23  9:01     ` Thomas Petazzoni via buildroot
2022-09-23 12:42       ` Gwenhael Goavec-Merou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220917175705.325903a1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=gwenhael.goavec-merou@trabucayre.com \
    --cc=gwenj@trabucayre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox