Re: [Buildroot] [PATCH v2] package/gnuradio: bump version to 3.10.3.0

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Fri, 23 Sep 2022 10:40:05 +0200
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:

> > > +	select BR2_PACKAGE_PYTHON_NUMPY    
> > 
> > Why are you removing the "# runtime" comment here? Your patch doesn't
> > change numpy to a build time dependency.
> >   
> Your review of v1 has highliteted the fact numpy is required at runtime (of
> course) but also at the buildtime (cmake checks for dependencies and stop when
> a requirement isn't satisfied). This why I have removed this comment.

But how come target numpy is needed at *build* time ? Isn't this just a
silly check that makes sense in native build situation, but not in
cross-compilation situation ?

> > >  ifeq ($(BR2_PACKAGE_GNURADIO_PYTHON),y)
> > > -GNURADIO_DEPENDENCIES += python3
> > > +GNURADIO_DEPENDENCIES += python3 python-pybind \
> > > +	host-python-numpy host-python-packaging    
> > 
> > Could you clarify if you need python-pybind on the target or on the
> > host? And also explain in the commit log why host-python-numpy and
> > host-python-packaging are now needed?  
> True. I will do that. And bump to the 3.10.4.0 version at the same time.

Thanks! Make sure to be very clear on the explanations of which
dependency is needed on the host vs. on the target, and which is needed
at build time vs. run time.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot