From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Peter Seiderer <ps.report@gmx.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/rtl8812au-aircrack-ng: fix build failure due to double defined endianness
Date: Fri, 23 Sep 2022 23:39:56 +0200 [thread overview]
Message-ID: <20220923233956.4d6ebabc@windsurf> (raw)
In-Reply-To: <20220920220904.98162-1-giulio.benetti@benettiengineering.com>
On Wed, 21 Sep 2022 00:09:04 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> By default package rtl8812au-aircrack-ng uses CONFIG_PLATFORM_I386_PC that
> define -DCONFIG_LITTLE_ENDIAN and this can't be overridden since the
> USER_EXTRA_CFLAGS are assigned to EXTRA_CFLAGS in the beginning of Makefile
> while -DCONFIG_LITTLE_ENDIAN is assigned later.
> Instead of using the default CONFIG_PLATFORM_I386_PC let's set it to 'n'
> and let's use the same defines it uses:
> -DCONFIG_IOCTL_CFG80211
> -DRTW_USE_CFG80211_STA_EVENT
> This way -DCONFIG_BIG_ENDIAN can be define without the conflict of being
> defined with with the default -DCONFIG_LITTLE_ENDIAN.
> Let's also add Linux config FIXUPS to build the module correctly.
>
> Fixes:
> http://autobuild.buildroot.net/results/2e4ee705d0e2b728f102aac4e6729f11ef22be36/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> .../rtl8812au-aircrack-ng/rtl8812au-aircrack-ng.mk | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Applied to master, thanks. The Makefile of this driver, with those
zillions of CONFIG_PLATFORM_xyz conditions, is really horrible...
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-23 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 22:09 [Buildroot] [PATCH] package/rtl8812au-aircrack-ng: fix build failure due to double defined endianness Giulio Benetti
2022-09-23 21:39 ` Thomas Petazzoni [this message]
2022-09-23 21:49 ` Giulio Benetti
2022-09-30 14:03 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923233956.4d6ebabc@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=ps.report@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox