* [Buildroot] [PATCH] package/rtl8812au-aircrack-ng: fix build failure due to double defined endianness
@ 2022-09-20 22:09 Giulio Benetti
2022-09-23 21:39 ` Thomas Petazzoni
2022-09-30 14:03 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Giulio Benetti @ 2022-09-20 22:09 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Peter Seiderer
By default package rtl8812au-aircrack-ng uses CONFIG_PLATFORM_I386_PC that
define -DCONFIG_LITTLE_ENDIAN and this can't be overridden since the
USER_EXTRA_CFLAGS are assigned to EXTRA_CFLAGS in the beginning of Makefile
while -DCONFIG_LITTLE_ENDIAN is assigned later.
Instead of using the default CONFIG_PLATFORM_I386_PC let's set it to 'n'
and let's use the same defines it uses:
-DCONFIG_IOCTL_CFG80211
-DRTW_USE_CFG80211_STA_EVENT
This way -DCONFIG_BIG_ENDIAN can be define without the conflict of being
defined with with the default -DCONFIG_LITTLE_ENDIAN.
Let's also add Linux config FIXUPS to build the module correctly.
Fixes:
http://autobuild.buildroot.net/results/2e4ee705d0e2b728f102aac4e6729f11ef22be36/
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
.../rtl8812au-aircrack-ng/rtl8812au-aircrack-ng.mk | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/package/rtl8812au-aircrack-ng/rtl8812au-aircrack-ng.mk b/package/rtl8812au-aircrack-ng/rtl8812au-aircrack-ng.mk
index 60d81469c2..45a6ce5729 100644
--- a/package/rtl8812au-aircrack-ng/rtl8812au-aircrack-ng.mk
+++ b/package/rtl8812au-aircrack-ng/rtl8812au-aircrack-ng.mk
@@ -11,14 +11,25 @@ RTL8812AU_AIRCRACK_NG_LICENSE_FILES = LICENSE
RTL8812AU_AIRCRACK_NG_EXTRA_CFLAGS = \
-DCONFIG_$(call qstrip,$(BR2_ENDIAN))_ENDIAN \
+ -DCONFIG_IOCTL_CFG80211 \
+ -DRTW_USE_CFG80211_STA_EVENT \
-Wno-error=address \
-Wno-error=array-bounds \
-Wno-error=cast-function-type
RTL8812AU_AIRCRACK_NG_MODULE_MAKE_OPTS = \
+ CONFIG_PLATFORM_I386_PC=n \
CONFIG_88XXAU=m \
KVER=$(LINUX_VERSION_PROBED) \
USER_EXTRA_CFLAGS="$(RTL8812AU_AIRCRACK_NG_EXTRA_CFLAGS)"
+define RTL8812AU_AIRCRACK_NG_LINUX_CONFIG_FIXUPS
+ $(call KCONFIG_ENABLE_OPT,CONFIG_NET)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_USB_SUPPORT)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_USB)
+endef
+
$(eval $(kernel-module))
$(eval $(generic-package))
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8812au-aircrack-ng: fix build failure due to double defined endianness
2022-09-20 22:09 [Buildroot] [PATCH] package/rtl8812au-aircrack-ng: fix build failure due to double defined endianness Giulio Benetti
@ 2022-09-23 21:39 ` Thomas Petazzoni
2022-09-23 21:49 ` Giulio Benetti
2022-09-30 14:03 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2022-09-23 21:39 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Peter Seiderer, buildroot
On Wed, 21 Sep 2022 00:09:04 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> By default package rtl8812au-aircrack-ng uses CONFIG_PLATFORM_I386_PC that
> define -DCONFIG_LITTLE_ENDIAN and this can't be overridden since the
> USER_EXTRA_CFLAGS are assigned to EXTRA_CFLAGS in the beginning of Makefile
> while -DCONFIG_LITTLE_ENDIAN is assigned later.
> Instead of using the default CONFIG_PLATFORM_I386_PC let's set it to 'n'
> and let's use the same defines it uses:
> -DCONFIG_IOCTL_CFG80211
> -DRTW_USE_CFG80211_STA_EVENT
> This way -DCONFIG_BIG_ENDIAN can be define without the conflict of being
> defined with with the default -DCONFIG_LITTLE_ENDIAN.
> Let's also add Linux config FIXUPS to build the module correctly.
>
> Fixes:
> http://autobuild.buildroot.net/results/2e4ee705d0e2b728f102aac4e6729f11ef22be36/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> .../rtl8812au-aircrack-ng/rtl8812au-aircrack-ng.mk | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Applied to master, thanks. The Makefile of this driver, with those
zillions of CONFIG_PLATFORM_xyz conditions, is really horrible...
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8812au-aircrack-ng: fix build failure due to double defined endianness
2022-09-23 21:39 ` Thomas Petazzoni
@ 2022-09-23 21:49 ` Giulio Benetti
0 siblings, 0 replies; 4+ messages in thread
From: Giulio Benetti @ 2022-09-23 21:49 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Peter Seiderer, buildroot
On 23/09/22 23:39, Thomas Petazzoni wrote:
> On Wed, 21 Sep 2022 00:09:04 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>
>> By default package rtl8812au-aircrack-ng uses CONFIG_PLATFORM_I386_PC that
>> define -DCONFIG_LITTLE_ENDIAN and this can't be overridden since the
>> USER_EXTRA_CFLAGS are assigned to EXTRA_CFLAGS in the beginning of Makefile
>> while -DCONFIG_LITTLE_ENDIAN is assigned later.
>> Instead of using the default CONFIG_PLATFORM_I386_PC let's set it to 'n'
>> and let's use the same defines it uses:
>> -DCONFIG_IOCTL_CFG80211
>> -DRTW_USE_CFG80211_STA_EVENT
>> This way -DCONFIG_BIG_ENDIAN can be define without the conflict of being
>> defined with with the default -DCONFIG_LITTLE_ENDIAN.
>> Let's also add Linux config FIXUPS to build the module correctly.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/2e4ee705d0e2b728f102aac4e6729f11ef22be36/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> .../rtl8812au-aircrack-ng/rtl8812au-aircrack-ng.mk | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>
> Applied to master, thanks. The Makefile of this driver, with those
> zillions of CONFIG_PLATFORM_xyz conditions, is really horrible...
Never like libnss's one :-)
--
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/rtl8812au-aircrack-ng: fix build failure due to double defined endianness
2022-09-20 22:09 [Buildroot] [PATCH] package/rtl8812au-aircrack-ng: fix build failure due to double defined endianness Giulio Benetti
2022-09-23 21:39 ` Thomas Petazzoni
@ 2022-09-30 14:03 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-09-30 14:03 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Peter Seiderer, buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> By default package rtl8812au-aircrack-ng uses CONFIG_PLATFORM_I386_PC that
> define -DCONFIG_LITTLE_ENDIAN and this can't be overridden since the
> USER_EXTRA_CFLAGS are assigned to EXTRA_CFLAGS in the beginning of Makefile
> while -DCONFIG_LITTLE_ENDIAN is assigned later.
> Instead of using the default CONFIG_PLATFORM_I386_PC let's set it to 'n'
> and let's use the same defines it uses:
> -DCONFIG_IOCTL_CFG80211
> -DRTW_USE_CFG80211_STA_EVENT
> This way -DCONFIG_BIG_ENDIAN can be define without the conflict of being
> defined with with the default -DCONFIG_LITTLE_ENDIAN.
> Let's also add Linux config FIXUPS to build the module correctly.
> Fixes:
> http://autobuild.buildroot.net/results/2e4ee705d0e2b728f102aac4e6729f11ef22be36/
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Committed to 2022.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-30 14:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-20 22:09 [Buildroot] [PATCH] package/rtl8812au-aircrack-ng: fix build failure due to double defined endianness Giulio Benetti
2022-09-23 21:39 ` Thomas Petazzoni
2022-09-23 21:49 ` Giulio Benetti
2022-09-30 14:03 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox