* [Buildroot] [PATCH v2] package/chartjs: fix installation
@ 2022-09-26 9:52 Ignacy Gawędzki
2022-09-26 12:01 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Ignacy Gawędzki @ 2022-09-26 9:52 UTC (permalink / raw)
To: buildroot
Version 3.9.1 does not distribute a CSS file nor a bundle. Install
only the minified Javascript source.
http://autobuild.buildroot.net/?reason=chartjs-3.9.1
Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr>
---
Changes v1 -> v2:
- add link to autobuild failure
---
package/chartjs/chartjs.mk | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/package/chartjs/chartjs.mk b/package/chartjs/chartjs.mk
index 585b4be285..5ed4b3d9c3 100644
--- a/package/chartjs/chartjs.mk
+++ b/package/chartjs/chartjs.mk
@@ -13,12 +13,8 @@ CHARTJS_CPE_ID_VENDOR = chartjs
CHARTJS_CPE_ID_PRODUCT = chart.js
define CHARTJS_INSTALL_TARGET_CMDS
- $(INSTALL) -m 0644 -D $(@D)/dist/Chart.min.css \
- $(TARGET_DIR)/var/www/chartjs/css/Chart.css
- $(INSTALL) -m 0644 -D $(@D)/dist/Chart.min.js \
+ $(INSTALL) -m 0644 -D $(@D)/dist/chart.min.js \
$(TARGET_DIR)/var/www/chartjs/js/Chart.js
- $(INSTALL) -m 0644 -D $(@D)/dist/Chart.bundle.min.js \
- $(TARGET_DIR)/var/www/chartjs/js/Chart.bundle.js
endef
$(eval $(generic-package))
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH v2] package/chartjs: fix installation
2022-09-26 9:52 [Buildroot] [PATCH v2] package/chartjs: fix installation Ignacy Gawędzki
@ 2022-09-26 12:01 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2022-09-26 12:01 UTC (permalink / raw)
To: Ignacy Gawędzki; +Cc: buildroot
On Mon, 26 Sep 2022 11:52:03 +0200
Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr> wrote:
> Version 3.9.1 does not distribute a CSS file nor a bundle. Install
> only the minified Javascript source.
>
> http://autobuild.buildroot.net/?reason=chartjs-3.9.1
We want to have a link to one specific build issue. Indeed, imagine
other chartjs-3.9.1 build issues pop up once this issue has been fixed.
Then this link would no longer make sense, as we wouldn't know which
specific build issue it was fixing.
So I have replaced this link with a link to one specific occurrence of
the build issue, and applied. Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-26 12:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-26 9:52 [Buildroot] [PATCH v2] package/chartjs: fix installation Ignacy Gawędzki
2022-09-26 12:01 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox