Re: [Buildroot] [PATCH] package/dhcpcd: Fix kconfig option for privilege separation

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: feedback@dallmeier.com
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/dhcpcd: Fix kconfig option for privilege separation
Date: Fri, 14 Oct 2022 21:30:21 +0200	[thread overview]
Message-ID: <20221014193021.GD2503@scaer> (raw)
In-Reply-To: <59335227-32d1-9d2f-ce9c-4a7a45ea913b@dallmeier.com>

Andreas, All,

On 2022-10-14 11:10 +0200, feedback--- via buildroot spake thusly:
> Hi all,
> 
> we are not sure if this is even a bug, but BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP is not selectable via 'menuconfig' without setting a
> string for the bool value.

Thanks for the suggestion.

That was on purpose that this was not selectable, see the commit log
that introduced the option, 20dd9453f32c (package/dhcpcd: add
BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP), which referred to:

    https://patchwork.ozlabs.org/project/buildroot/patch/20210303091904.467706-1-fontaine.fabrice@gmail.com

which basically said (paraphrasing):

    For such complex conditions, it is easier to introduce a Kconfig
    symbol, rather than write complex Makefile code in the .mk file.

Indeed, before 20dd9453f32c, there were quite a few repetitive code
blocks to handle each of them, see commit d412539dbca2 (package/dhcpcd:
disable privsep on older kernels).

Can you explain why you'd want to explicitly disable privilege
separation in dhcpcd?

> --- a/package/dhcpcd/Config.in
> +++ b/package/dhcpcd/Config.in
> @@ -12,7 +12,7 @@ config BR2_PACKAGE_DHCPCD
>  if BR2_PACKAGE_DHCPCD
>  
>  config BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP
> -       bool
> +       bool "enable privilege separation"
>         default y
>         depends on BR2_USE_MMU
>         # Audit headers were only added in recent kernels for some arches
> 
> Best regards,
> Andreas

> <html>

Please, avoid html mail; our patchwork did not even catch it:
    https://patchwork.ozlabs.org/project/buildroot/list/

Next time, please use "git send-email", which sends patches in a format
ready to be digested to be applied easily.

Regards,
Yann E. MORIN.

>   <head>
>     <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
>   </head>
>   <body>
>     <font face="monospace">Hi all,<br>
>       <br>
>       we are not sure if this is even a bug, but
>       BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP is not selectable via
>       'menuconfig' without setting a string for the bool value.<br>
>       <br>
>       --- a/package/dhcpcd/Config.in<br>
>       +++ b/package/dhcpcd/Config.in<br>
>       @@ -12,7 +12,7 @@ config BR2_PACKAGE_DHCPCD<br>
>        if BR2_PACKAGE_DHCPCD<br>
>        <br>
>        config BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP<br>
>       -       bool<br>
>       +       bool "enable privilege separation"<br>
>               default y<br>
>               depends on BR2_USE_MMU<br>
>               # Audit headers were only added in recent kernels for some
>       arches<br>
>       <br>
>       Best regards,<br>
>       Andreas<br>
>       <br>
>     </font>
>   </body>
> </html>

> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot