* [Buildroot] [PATCH] package/dhcpcd: Fix kconfig option for privilege separation @ 2022-10-14 9:10 feedback--- via buildroot 2022-10-14 19:30 ` Yann E. MORIN 0 siblings, 1 reply; 3+ messages in thread From: feedback--- via buildroot @ 2022-10-14 9:10 UTC (permalink / raw) To: buildroot [-- Attachment #1: Type: text/html, Size: 945 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/dhcpcd: Fix kconfig option for privilege separation 2022-10-14 9:10 [Buildroot] [PATCH] package/dhcpcd: Fix kconfig option for privilege separation feedback--- via buildroot @ 2022-10-14 19:30 ` Yann E. MORIN 2022-10-18 11:49 ` feedback--- via buildroot 0 siblings, 1 reply; 3+ messages in thread From: Yann E. MORIN @ 2022-10-14 19:30 UTC (permalink / raw) To: feedback; +Cc: buildroot Andreas, All, On 2022-10-14 11:10 +0200, feedback--- via buildroot spake thusly: > Hi all, > > we are not sure if this is even a bug, but BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP is not selectable via 'menuconfig' without setting a > string for the bool value. Thanks for the suggestion. That was on purpose that this was not selectable, see the commit log that introduced the option, 20dd9453f32c (package/dhcpcd: add BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP), which referred to: https://patchwork.ozlabs.org/project/buildroot/patch/20210303091904.467706-1-fontaine.fabrice@gmail.com which basically said (paraphrasing): For such complex conditions, it is easier to introduce a Kconfig symbol, rather than write complex Makefile code in the .mk file. Indeed, before 20dd9453f32c, there were quite a few repetitive code blocks to handle each of them, see commit d412539dbca2 (package/dhcpcd: disable privsep on older kernels). Can you explain why you'd want to explicitly disable privilege separation in dhcpcd? > --- a/package/dhcpcd/Config.in > +++ b/package/dhcpcd/Config.in > @@ -12,7 +12,7 @@ config BR2_PACKAGE_DHCPCD > if BR2_PACKAGE_DHCPCD > > config BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP > - bool > + bool "enable privilege separation" > default y > depends on BR2_USE_MMU > # Audit headers were only added in recent kernels for some arches > > Best regards, > Andreas > <html> Please, avoid html mail; our patchwork did not even catch it: https://patchwork.ozlabs.org/project/buildroot/list/ Next time, please use "git send-email", which sends patches in a format ready to be digested to be applied easily. Regards, Yann E. MORIN. > <head> > <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> > </head> > <body> > <font face="monospace">Hi all,<br> > <br> > we are not sure if this is even a bug, but > BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP is not selectable via > 'menuconfig' without setting a string for the bool value.<br> > <br> > --- a/package/dhcpcd/Config.in<br> > +++ b/package/dhcpcd/Config.in<br> > @@ -12,7 +12,7 @@ config BR2_PACKAGE_DHCPCD<br> > if BR2_PACKAGE_DHCPCD<br> > <br> > config BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP<br> > - bool<br> > + bool "enable privilege separation"<br> > default y<br> > depends on BR2_USE_MMU<br> > # Audit headers were only added in recent kernels for some > arches<br> > <br> > Best regards,<br> > Andreas<br> > <br> > </font> > </body> > </html> > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/dhcpcd: Fix kconfig option for privilege separation 2022-10-14 19:30 ` Yann E. MORIN @ 2022-10-18 11:49 ` feedback--- via buildroot 0 siblings, 0 replies; 3+ messages in thread From: feedback--- via buildroot @ 2022-10-18 11:49 UTC (permalink / raw) To: Yann E. MORIN; +Cc: buildroot On 2022-10-14 21:30, Yann E. MORIN wrote: > Andreas, All, > > On 2022-10-14 11:10 +0200, feedback--- via buildroot spake thusly: >> Hi all, >> >> we are not sure if this is even a bug, but BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP is not selectable via 'menuconfig' without setting a >> string for the bool value. > > Thanks for the suggestion. > > That was on purpose that this was not selectable, see the commit log > that introduced the option, 20dd9453f32c (package/dhcpcd: add > BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP), which referred to: > > https://patchwork.ozlabs.org/project/buildroot/patch/20210303091904.467706-1-fontaine.fabrice@gmail.com > > which basically said (paraphrasing): > > For such complex conditions, it is easier to introduce a Kconfig > symbol, rather than write complex Makefile code in the .mk file. > > Indeed, before 20dd9453f32c, there were quite a few repetitive code > blocks to handle each of them, see commit d412539dbca2 (package/dhcpcd: > disable privsep on older kernels). > > Can you explain why you'd want to explicitly disable privilege > separation in dhcpcd? Thank you for the explanation. I didn't know that you use the kconfig values also for other purposes sometimes. First we thought the kernel version from one of our systems is too old because of some strange error messages during startup of dhcpcd, but it seems that there was another problem involved which has been fixed. I have turned privilege separation back on for now. >> --- a/package/dhcpcd/Config.in >> +++ b/package/dhcpcd/Config.in >> @@ -12,7 +12,7 @@ config BR2_PACKAGE_DHCPCD >> if BR2_PACKAGE_DHCPCD >> >> config BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP >> - bool >> + bool "enable privilege separation" >> default y >> depends on BR2_USE_MMU >> # Audit headers were only added in recent kernels for some arches >> >> Best regards, >> Andreas > >> <html> > > Please, avoid html mail; our patchwork did not even catch it: > https://patchwork.ozlabs.org/project/buildroot/list/ > > Next time, please use "git send-email", which sends patches in a format > ready to be digested to be applied easily. Sorry for the HTML mail, this one is text hopefully. > Regards, > Yann E. MORIN. > >> <head> >> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> >> </head> >> <body> >> <font face="monospace">Hi all,<br> >> <br> >> we are not sure if this is even a bug, but >> BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP is not selectable via >> 'menuconfig' without setting a string for the bool value.<br> >> <br> >> --- a/package/dhcpcd/Config.in<br> >> +++ b/package/dhcpcd/Config.in<br> >> @@ -12,7 +12,7 @@ config BR2_PACKAGE_DHCPCD<br> >> if BR2_PACKAGE_DHCPCD<br> >> <br> >> config BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP<br> >> - bool<br> >> + bool "enable privilege separation"<br> >> default y<br> >> depends on BR2_USE_MMU<br> >> # Audit headers were only added in recent kernels for some >> arches<br> >> <br> >> Best regards,<br> >> Andreas<br> >> <br> >> </font> >> </body> >> </html> > >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot > > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-18 11:49 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-10-14 9:10 [Buildroot] [PATCH] package/dhcpcd: Fix kconfig option for privilege separation feedback--- via buildroot 2022-10-14 19:30 ` Yann E. MORIN 2022-10-18 11:49 ` feedback--- via buildroot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox