[Buildroot] [PATCH 1/2] package/iwd: drop dbus check

[Buildroot] [PATCH 1/2] package/iwd: drop dbus check

[Lang Daniel via buildroot]

Since 6f5f6bcd8 dbus is selected when iwd is selected.

Signed-off-by: Daniel Lang <d.lang@abatec.at>
---
 package/iwd/iwd.mk | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
index fc10c5f1d4..8497fd1141 100644
--- a/package/iwd/iwd.mk
+++ b/package/iwd/iwd.mk
@@ -17,15 +17,10 @@ IWD_AUTORECONF = YES
 
 IWD_CONF_OPTS = \
 	--disable-manual-pages \
-	--enable-external-ell
-IWD_DEPENDENCIES = ell
-
-ifeq ($(BR2_PACKAGE_DBUS),y)
-IWD_CONF_OPTS += --enable-dbus-policy --with-dbus-datadir=/usr/share
-IWD_DEPENDENCIES += dbus
-else
-IWD_CONF_OPTS += --disable-dbus-policy
-endif
+	--enable-external-ell \
+	--enable-dbus-policy \
+	--with-dbus-datadir=/usr/share
+IWD_DEPENDENCIES = ell dbus
 
 ifeq ($(BR2_PACKAGE_READLINE),y)
 # iwd client depends on readline (GPL-3.0+)
-- 
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/iwd: drop dbus check

[Yann E. MORIN]

Daniel, All,

On 2022-10-13 15:01 +0000, Lang Daniel via buildroot spake thusly:
> Since 6f5f6bcd8 dbus is selected when iwd is selected.
> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> ---
>  package/iwd/iwd.mk | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
> index fc10c5f1d4..8497fd1141 100644
> --- a/package/iwd/iwd.mk
> +++ b/package/iwd/iwd.mk
> @@ -17,15 +17,10 @@ IWD_AUTORECONF = YES
>  
>  IWD_CONF_OPTS = \
>  	--disable-manual-pages \
> -	--enable-external-ell
> -IWD_DEPENDENCIES = ell
> -
> -ifeq ($(BR2_PACKAGE_DBUS),y)
> -IWD_CONF_OPTS += --enable-dbus-policy --with-dbus-datadir=/usr/share
> -IWD_DEPENDENCIES += dbus
> -else
> -IWD_CONF_OPTS += --disable-dbus-policy
> -endif
> +	--enable-external-ell \
> +	--enable-dbus-policy \
> +	--with-dbus-datadir=/usr/share
> +IWD_DEPENDENCIES = ell dbus

Why keep a build-time dependency on dbus, if it really is a runtime
dependency as noted in Config.in ?

Can you double-check that iwd does not end up linked to libdbus?

Then, send an update: either drop the build dependency if it really is a
runtiem one, or fix the Config.in comment if it is still needed at build
time.

Regards,
Yann E. MORIN.

>  ifeq ($(BR2_PACKAGE_READLINE),y)
>  # iwd client depends on readline (GPL-3.0+)
> -- 
> 2.25.1
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot