Re: [Buildroot] [PATCH] rtl8188eu: remove package

[Peter Seiderer <ps.report@gmx.net>]

Hello Luca, *,

On Mon, 17 Oct 2022 09:39:53 +0200, Luca Ceresoli via buildroot <buildroot@buildroot.org> wrote:

> From: Luca Ceresoli <luca.ceresoli@bootlin.com>
> 
> This package fails building with a kernel >= 6.0 [0] due to internal API
> changes [1]:
> 
>   .../ioctl_cfg80211.c: In function ‘rtw_cfg80211_indicate_connect’:
>   ...ioctl_cfg80211.c:709:12: error: ‘struct cfg80211_roam_info’ has no member named ‘channel’
>   709 |   roam_info.channel = notify_channel;
>       |            ^
>   ...ioctl_cfg80211.c:710:12: error: ‘struct cfg80211_roam_info’ has no member named ‘bssid’
>   710 |   roam_info.bssid = cur_network->network.MacAddress;
>       |            ^
> 
> There is currently no fix in the github repository, and it's probably not
> worth fixing because, as the Config.in help text states:
> 
>   This is needed only for Linux kernels before 3.12.
>   Since 3.12, there is a (staging) driver in mainline, with a
>   similar codebase.

Despite the buildroot help text the rtl8188eu code base is still maintained
see e.g. 'rtl8188eu: Fix builds for kernel 6.0 '([2]) and the various forks/upstream
versions tend to support different feature sets regarding IBSS and/or monitor
mode etc. - not sure about this one but valid for some other rtlxxxx ones),

Regards,
Peter

[2] https://github.com/lwfinger/rtl8188eu/commit/0a5e81555c5e9dc16030598d4e11f8f1dad541be


> 
> Kernel 3.12 is 9 years old now, and the oldest kernel currently supported
> is 4.9.
> 
> [0] http://autobuild.buildroot.org/results/550/550640296a92826f6f04d2344adde75c3025ea35/
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/include/net/cfg80211.h?id=efbabc11650040c64884ff3019b88c7bcc0ceb1d
> 
> Cc: TIAN Yuanhao <tianyuanhao3@163.com>
> Cc: Petr Vorel <petr.vorel@gmail.com>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Cc: Heiko Thiery <heiko.thiery@gmail.com>
> Cc: William Wennerström <william@willeponken.me>
> Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
>  DEVELOPERS                       |  1 -
>  package/Config.in                |  1 -
>  package/rtl8188eu/Config.in      | 21 ---------------------
>  package/rtl8188eu/rtl8188eu.hash |  3 ---
>  package/rtl8188eu/rtl8188eu.mk   | 28 ----------------------------
>  5 files changed, 54 deletions(-)
>  delete mode 100644 package/rtl8188eu/Config.in
>  delete mode 100644 package/rtl8188eu/rtl8188eu.hash
>  delete mode 100644 package/rtl8188eu/rtl8188eu.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index c0e6f8bbef3d..b1e84edd5e9a 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1810,7 +1810,6 @@ F:	package/agentpp/
>  F:	package/exim/
>  F:	package/libpjsip/
>  F:	package/qpid-proton/
> -F:	package/rtl8188eu/
>  F:	package/snmppp/
>  F:	package/stm32flash/
>  F:	package/unzip/
> diff --git a/package/Config.in b/package/Config.in
> index e3a34d6e97d3..d95a6ac4e3fb 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -573,7 +573,6 @@ endmenu
>  	source "package/rpi-userland/Config.in"
>  	source "package/rs485conf/Config.in"
>  	source "package/rtc-tools/Config.in"
> -	source "package/rtl8188eu/Config.in"
>  	source "package/rtl8189es/Config.in"
>  	source "package/rtl8189fs/Config.in"
>  	source "package/rtl8723bu/Config.in"
> diff --git a/package/rtl8188eu/Config.in b/package/rtl8188eu/Config.in
> deleted file mode 100644
> index 76d90852976a..000000000000
> --- a/package/rtl8188eu/Config.in
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -config BR2_PACKAGE_RTL8188EU
> -	bool "rtl8188eu"
> -	depends on !BR2_s390x
> -	depends on BR2_LINUX_KERNEL
> -	help
> -	  A standalone driver for the RTL8188EU USB Wi-Fi adapter.
> -	  This is needed only for Linux kernels before 3.12.
> -	  Since 3.12, there is a (staging) driver in mainline, with a
> -	  similar codebase.
> -
> -	  Make sure your target kernel has the CONFIG_WIRELESS_EXT
> -	  config option enabled.
> -
> -	  Note: this package needs a firmware loading mechanism to load
> -	  the binary blob for the chip to work.
> -
> -	  https://github.com/lwfinger/rtl8188eu
> -
> -comment "rtl8188eu needs a Linux kernel to be built"
> -	depends on !BR2_s390x
> -	depends on !BR2_LINUX_KERNEL
> diff --git a/package/rtl8188eu/rtl8188eu.hash b/package/rtl8188eu/rtl8188eu.hash
> deleted file mode 100644
> index 9c7f2de4b61e..000000000000
> --- a/package/rtl8188eu/rtl8188eu.hash
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -# Locally computed
> -sha256  6bc46a13b20a2ed121844e51fd690216b2ab3b1faa1af8d9501090026ca9bd22  rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90.tar.gz
> -sha256  af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7  COPYING
> diff --git a/package/rtl8188eu/rtl8188eu.mk b/package/rtl8188eu/rtl8188eu.mk
> deleted file mode 100644
> index ebce4617ac5c..000000000000
> --- a/package/rtl8188eu/rtl8188eu.mk
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -################################################################################
> -#
> -# rtl8188eu
> -#
> -################################################################################
> -
> -RTL8188EU_VERSION = 903b6fcb821465fe9c63e83416080df70c1c3c90
> -RTL8188EU_SITE = $(call github,lwfinger,rtl8188eu,$(RTL8188EU_VERSION))
> -RTL8188EU_LICENSE = GPL-2.0, proprietary (rtl8188eufw.bin firmware blob)
> -RTL8188EU_LICENSE_FILES = COPYING
> -RTL8188EU_MODULE_MAKE_OPTS = CONFIG_RTL8188EU=m
> -
> -define RTL8188EU_LINUX_CONFIG_FIXUPS
> -	$(call KCONFIG_ENABLE_OPT,CONFIG_NET)
> -	$(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
> -	$(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
> -	$(call KCONFIG_ENABLE_OPT,CONFIG_USB_SUPPORT)
> -	$(call KCONFIG_ENABLE_OPT,CONFIG_USB)
> -endef
> -
> -define RTL8188EU_INSTALL_FIRMWARE
> -	$(INSTALL) -D -m 644 $(@D)/rtl8188eufw.bin \
> -		$(TARGET_DIR)/lib/firmware/rtlwifi/rtl8188eufw.bin
> -endef
> -RTL8188EU_POST_INSTALL_TARGET_HOOKS += RTL8188EU_INSTALL_FIRMWARE
> -
> -$(eval $(kernel-module))
> -$(eval $(generic-package))

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot