From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Peter Seiderer <ps.report@gmx.net>
Cc: "Bernd Kuhls" <bernd.kuhls@t-online.de>,
"Luca Ceresoli via buildroot" <buildroot@buildroot.org>,
"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
"TIAN Yuanhao" <tianyuanhao3@163.com>,
"William Wennerström" <william@willeponken.me>,
"Heiko Thiery" <heiko.thiery@gmail.com>
Subject: Re: [Buildroot] [PATCH] rtl8188eu: remove package
Date: Tue, 18 Oct 2022 08:59:43 +0200 [thread overview]
Message-ID: <20221018085943.104f227f@booty> (raw)
In-Reply-To: <20221017211048.43d2394c@gmx.net>
Hi Peter, Giulio, Petr,
Thank you all for the feedback -- I see my patch worked effectively :)
You all seem to know way more than I do, which is not surprising as I'm not
actively using this package anymore.
On Mon, 17 Oct 2022 21:10:48 +0200
Peter Seiderer <ps.report@gmx.net> wrote:
> Hello Luca, *,
>
> On Mon, 17 Oct 2022 09:39:53 +0200, Luca Ceresoli via buildroot <buildroot@buildroot.org> wrote:
>
> > From: Luca Ceresoli <luca.ceresoli@bootlin.com>
> >
> > This package fails building with a kernel >= 6.0 [0] due to internal API
> > changes [1]:
> >
> > .../ioctl_cfg80211.c: In function ‘rtw_cfg80211_indicate_connect’:
> > ...ioctl_cfg80211.c:709:12: error: ‘struct cfg80211_roam_info’ has no member named ‘channel’
> > 709 | roam_info.channel = notify_channel;
> > | ^
> > ...ioctl_cfg80211.c:710:12: error: ‘struct cfg80211_roam_info’ has no member named ‘bssid’
> > 710 | roam_info.bssid = cur_network->network.MacAddress;
> > | ^
> >
> > There is currently no fix in the github repository, and it's probably not
> > worth fixing because, as the Config.in help text states:
> >
> > This is needed only for Linux kernels before 3.12.
> > Since 3.12, there is a (staging) driver in mainline, with a
> > similar codebase.
>
> Despite the buildroot help text the rtl8188eu code base is still maintained
> see e.g. 'rtl8188eu: Fix builds for kernel 6.0 '([2]) and the various forks/upstream
> versions tend to support different feature sets regarding IBSS and/or monitor
> mode etc. - not sure about this one but valid for some other rtlxxxx ones),
Good to know! Why not adding this info to Config.in too? It would avoid
others trying to remove the package again.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-18 6:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 7:39 [Buildroot] [PATCH] rtl8188eu: remove package Luca Ceresoli via buildroot
2022-10-17 19:10 ` Peter Seiderer
2022-10-17 20:19 ` Giulio Benetti
2022-10-17 22:21 ` Petr Vorel
2022-10-17 22:34 ` Petr Vorel
2022-10-18 6:59 ` Luca Ceresoli via buildroot [this message]
2022-10-18 13:15 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018085943.104f227f@booty \
--to=buildroot@buildroot.org \
--cc=bernd.kuhls@t-online.de \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko.thiery@gmail.com \
--cc=luca.ceresoli@bootlin.com \
--cc=ps.report@gmx.net \
--cc=tianyuanhao3@163.com \
--cc=william@willeponken.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox