* [Buildroot] [PATCH 1/1] package/nodejs: bypass configure shell wrapper
@ 2022-10-25 19:02 James Hilliard
2022-10-25 20:57 ` Thomas Petazzoni via buildroot
2022-11-05 10:02 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: James Hilliard @ 2022-10-25 19:02 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard, Daniel Price, Martin Bark
The configure file is a shell script which searches for a predefined
python binary and then calls configure.py with that.
As we already call configure with the desired python binary we should
call configure.py directly so that the expected python binary is used
and so that the shell wrapper doesn't throw spurious interpreter
validation errors.
This also avoid spurious errors due to the configure shell wrapper
missing supported python versions, for example this fixes:
Node.js configure: Found Python 3.11.0...
Please use python3.10 or python3.9 or python3.8 or python3.7 or python3.6.
/usr/bin/python3.10 ./configure
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/nodejs/nodejs.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 05456e3443..29a10b900f 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -88,7 +88,7 @@ define HOST_NODEJS_CONFIGURE_CMDS
$(HOST_CONFIGURE_OPTS) \
PATH=$(@D)/bin:$(BR_PATH) \
PYTHON=$(HOST_DIR)/bin/python3 \
- $(HOST_DIR)/bin/python3 ./configure \
+ $(HOST_DIR)/bin/python3 configure.py \
--prefix=$(HOST_DIR) \
--without-dtrace \
--without-etw \
@@ -200,7 +200,7 @@ define NODEJS_CONFIGURE_CMDS
LDFLAGS="$(NODEJS_LDFLAGS)" \
LD="$(TARGET_CXX)" \
PYTHON=$(HOST_DIR)/bin/python3 \
- $(HOST_DIR)/bin/python3 ./configure \
+ $(HOST_DIR)/bin/python3 configure.py \
--prefix=/usr \
--dest-cpu=$(NODEJS_CPU) \
$(if $(NODEJS_ARM_FP),--with-arm-float-abi=$(NODEJS_ARM_FP)) \
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/nodejs: bypass configure shell wrapper
2022-10-25 19:02 [Buildroot] [PATCH 1/1] package/nodejs: bypass configure shell wrapper James Hilliard
@ 2022-10-25 20:57 ` Thomas Petazzoni via buildroot
2022-11-05 10:02 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-10-25 20:57 UTC (permalink / raw)
To: James Hilliard; +Cc: Martin Bark, Daniel Price, buildroot
On Tue, 25 Oct 2022 13:02:36 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> The configure file is a shell script which searches for a predefined
> python binary and then calls configure.py with that.
>
> As we already call configure with the desired python binary we should
> call configure.py directly so that the expected python binary is used
> and so that the shell wrapper doesn't throw spurious interpreter
> validation errors.
>
> This also avoid spurious errors due to the configure shell wrapper
> missing supported python versions, for example this fixes:
> Node.js configure: Found Python 3.11.0...
> Please use python3.10 or python3.9 or python3.8 or python3.7 or python3.6.
> /usr/bin/python3.10 ./configure
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/nodejs/nodejs.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/nodejs: bypass configure shell wrapper
2022-10-25 19:02 [Buildroot] [PATCH 1/1] package/nodejs: bypass configure shell wrapper James Hilliard
2022-10-25 20:57 ` Thomas Petazzoni via buildroot
@ 2022-11-05 10:02 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-11-05 10:02 UTC (permalink / raw)
To: James Hilliard; +Cc: Martin Bark, Daniel Price, buildroot
>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:
> The configure file is a shell script which searches for a predefined
> python binary and then calls configure.py with that.
> As we already call configure with the desired python binary we should
> call configure.py directly so that the expected python binary is used
> and so that the shell wrapper doesn't throw spurious interpreter
> validation errors.
> This also avoid spurious errors due to the configure shell wrapper
> missing supported python versions, for example this fixes:
> Node.js configure: Found Python 3.11.0...
> Please use python3.10 or python3.9 or python3.8 or python3.7 or python3.6.
> /usr/bin/python3.10 ./configure
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Committed to 2022.08.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-05 10:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-25 19:02 [Buildroot] [PATCH 1/1] package/nodejs: bypass configure shell wrapper James Hilliard
2022-10-25 20:57 ` Thomas Petazzoni via buildroot
2022-11-05 10:02 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox