[Buildroot] [PATCH] package/nodejs: drop support for the MIPS architecture

[Buildroot] [PATCH] package/nodejs: drop support for the MIPS architecture

[Thomas Petazzoni via buildroot]

The build of NodeJS fails on mipsel due to an issue in the V8 code:

../../deps/v8/src/compiler/backend/mips/code-generator-mips.cc:4106:48: error: call of overloaded 'Operand(int64_t)' is ambiguous
 4106 |                 Operand(static_cast<int64_t>(0)));

There is apparently a lack of maintenance of the MIPS port of V8, as
is discussed in the Github issue at
https://github.com/nodejs/node/issues/26179.

Until this get improved/fixed, our best option is to drop support for
MIPS in our NodeJS package.

Fixes:

  http://autobuild.buildroot.net/results/0e6ee80c77bcb77afe18410e8d9da93b738cb0a4/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/nodejs/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
index 5375dfeacd..1489306be0 100644
--- a/package/nodejs/Config.in
+++ b/package/nodejs/Config.in
@@ -2,7 +2,6 @@ config BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
 	bool
 	# On ARM, at least ARMv6+ with VFPv2+ is needed
 	default y if BR2_arm && !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV5 && BR2_ARM_CPU_HAS_VFPV2
-	default y if BR2_mipsel && !BR2_MIPS_SOFT_FLOAT
 	default y if BR2_aarch64 || BR2_i386 || BR2_x86_64
 	# libuv
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
-- 
2.37.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/nodejs: drop support for the MIPS architecture

[Thomas Petazzoni via buildroot]

On Wed, 26 Oct 2022 19:57:05 +0200
Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:

> The build of NodeJS fails on mipsel due to an issue in the V8 code:
> 
> ../../deps/v8/src/compiler/backend/mips/code-generator-mips.cc:4106:48: error: call of overloaded 'Operand(int64_t)' is ambiguous
>  4106 |                 Operand(static_cast<int64_t>(0)));
> 
> There is apparently a lack of maintenance of the MIPS port of V8, as
> is discussed in the Github issue at
> https://github.com/nodejs/node/issues/26179.
> 
> Until this get improved/fixed, our best option is to drop support for
> MIPS in our NodeJS package.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/0e6ee80c77bcb77afe18410e8d9da93b738cb0a4/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/nodejs/Config.in | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/nodejs: drop support for the MIPS architecture

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > The build of NodeJS fails on mipsel due to an issue in the V8 code:
 > ../../deps/v8/src/compiler/backend/mips/code-generator-mips.cc:4106:48: error: call of overloaded 'Operand(int64_t)' is ambiguous
 >  4106 |                 Operand(static_cast<int64_t>(0)));

 > There is apparently a lack of maintenance of the MIPS port of V8, as
 > is discussed in the Github issue at
 > https://github.com/nodejs/node/issues/26179.

 > Until this get improved/fixed, our best option is to drop support for
 > MIPS in our NodeJS package.

 > Fixes:

 >   http://autobuild.buildroot.net/results/0e6ee80c77bcb77afe18410e8d9da93b738cb0a4/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

:/

Committed to 2022.08.x, thanks.

Perhaps this is only a >= nodejs 16.x issue? We don't seem to have any
similar build issues for 14.x on 2022.02.x.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/nodejs: drop support for the MIPS architecture

[Thomas Petazzoni via buildroot]

On Wed, 09 Nov 2022 14:28:31 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

> Committed to 2022.08.x, thanks.
> 
> Perhaps this is only a >= nodejs 16.x issue? We don't seem to have any
> similar build issues for 14.x on 2022.02.x.

I honestly didn't look at older releases. It is indeed possible that it
used to work, since when MIPS support was added I suppose someone was
using it :-)

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot