From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Tim Gover <tim.gover@raspberrypi.com>
Cc: Martin Bark <martin@barkynet.com>,
Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/rpi-firmware: add overlays/README
Date: Mon, 31 Oct 2022 13:39:28 +0100 [thread overview]
Message-ID: <20221031123928.GB1058960@scaer> (raw)
In-Reply-To: <20221031114643.6648-1-tim.gover@raspberrypi.com>
Tim, All,
On 2022-10-31 11:46 +0000, Tim Gover spake thusly:
> If a custom os_prefix directory is specified then the Raspberry Pi
> firmware probes for the README file in overlays directory.
>
> Since the README file is small let's include it, otherwise,
197KiB is _not_ small. In fact, the README is bigger than every dtbo,
and accounts for ~25% of the size of all dtbo combined.
> the firmware won't recognize the overlays directory if the user
> later moves it to an os_prefix specific sub-directory.
What is the goal here, in the context of Buildroot, where we only
install one set of overlays?
If a user moved the overlays, they already have a script that does that,
so they should also ensure that script properly prepares config.txt to
specify the proper os_prefix, and so it is just a matter of adding a
'touch' on the README in the same script.
Regards,
Yann E. MORIN.
> From
> https://www.raspberrypi.com/documentation/computers/config_txt.html#overlay_prefix
>
> Unless ${os_prefix}${overlay_prefix}README exists, overlays are shared
> with the main OS (i.e. os_prefix is ignored).
>
> Signed-off-by: Tim Gover <tim.gover@raspberrypi.com>
> ---
> package/rpi-firmware/rpi-firmware.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index d4d1d07b3f..908d7def6a 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -48,6 +48,7 @@ define RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
> $(foreach ovldtb,$(wildcard $(@D)/boot/overlays/*.dtbo), \
> $(INSTALL) -D -m 0644 $(ovldtb) $(BINARIES_DIR)/rpi-firmware/overlays/$(notdir $(ovldtb))
> )
> + $(INSTALL) -D -m 0644 $(@D)/boot/overlays/README $(BINARIES_DIR)/rpi-firmware/overlays/
> $(INSTALL) -D -m 0644 $(@D)/boot/overlays/overlay_map.dtb $(BINARIES_DIR)/rpi-firmware/overlays/
> endef
> else
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-31 12:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:46 [Buildroot] [PATCH 1/1] package/rpi-firmware: add overlays/README Tim Gover
2022-10-31 12:39 ` Yann E. MORIN [this message]
2022-10-31 12:52 ` Tim Gover
2022-10-31 13:14 ` Yann E. MORIN
2022-10-31 15:02 ` Tim Gover
-- strict thread matches above, loose matches on Subject: below --
2022-10-31 15:02 Tim Gover
2022-11-22 22:33 ` Thomas Petazzoni via buildroot
2022-11-23 10:51 ` Tim Gover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031123928.GB1058960@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=mahyar.koshkouei@gmail.com \
--cc=martin@barkynet.com \
--cc=tim.gover@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox