From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Tim Gover <tim.gover@raspberrypi.com>
Cc: Martin Bark <martin@barkynet.com>,
Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/rpi-firmware: add overlays/README
Date: Tue, 22 Nov 2022 23:33:50 +0100 [thread overview]
Message-ID: <20221122233350.6b00aa83@windsurf> (raw)
In-Reply-To: <20221031150235.12074-1-tim.gover@raspberrypi.com>
Hello Tim,
On Mon, 31 Oct 2022 15:02:35 +0000
Tim Gover <tim.gover@raspberrypi.com> wrote:
> If a custom os_prefix directory is specified then the Raspberry Pi
> firmware probes for the README file in overlays directory. If
> this is not found then firmware will use the top-level overlays
> directory which can be confusing if os_prefix is used in conjunction
> with other filters to implement alternate boot behaviour.
>
> In Raspberry Pi OS the README file is always included to ensure
> that the relevant documenation is in sync with the overlays. Rather
> that including the entire file let's just include an emtpy file so
> that overlays directory is consistent with the Raspberry Pi OS
> APT package.
>
> From
> https://www.raspberrypi.com/documentation/computers/config_txt.html#overlay_prefix
>
> Unless ${os_prefix}${overlay_prefix}README exists, overlays are shared
> with the main OS (i.e. os_prefix is ignored).
>
> Signed-off-by: Tim Gover <tim.gover@raspberrypi.com>
> ---
> package/rpi-firmware/rpi-firmware.mk | 1 +
> 1 file changed, 1 insertion(+)
I am not entirely sure how useful ${os_prefix} is in the context of a
Buildroot generated system, but I guess having this empty README file
doesn't hurt much, so I've applied to next. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-11-22 22:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 15:02 [Buildroot] [PATCH 1/1] package/rpi-firmware: add overlays/README Tim Gover
2022-11-22 22:33 ` Thomas Petazzoni via buildroot [this message]
2022-11-23 10:51 ` Tim Gover
-- strict thread matches above, loose matches on Subject: below --
2022-10-31 11:46 Tim Gover
2022-10-31 12:39 ` Yann E. MORIN
2022-10-31 12:52 ` Tim Gover
2022-10-31 13:14 ` Yann E. MORIN
2022-10-31 15:02 ` Tim Gover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122233350.6b00aa83@windsurf \
--to=buildroot@buildroot.org \
--cc=mahyar.koshkouei@gmail.com \
--cc=martin@barkynet.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tim.gover@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox