[Buildroot] [PATCH 1/1] package/alsa-utils: update dependency for topology support

[Buildroot] [PATCH 1/1] package/alsa-utils: update dependency for topology support

[Bernd Kuhls]

This is a follow-up patch for

https://git.busybox.net/buildroot/commit/?id=28497102e1788df3628bd3324a3304a03c7942d0

which created a new option for topology support in alsa-lib, this
dependency was not ported over to alsa-utils.

Fixes:
http://autobuild.buildroot.net/results/a9c9f5157365efe8271bf69dab0d5a5532b196ea/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/alsa-utils/Config.in | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
index 555f06fd21..8f2a661e3a 100644
--- a/package/alsa-utils/Config.in
+++ b/package/alsa-utils/Config.in
@@ -45,10 +45,7 @@ config BR2_PACKAGE_ALSA_UTILS_ALSAUCM
 
 config BR2_PACKAGE_ALSA_UTILS_ALSATPLG
 	bool "alsatplg"
-	depends on !BR2_STATIC_LIBS # dlfcn.h
-
-comment "alsatplg needs a toolchain w/ dynamic library"
-	depends on BR2_STATIC_LIBS
+	depends on BR2_PACKAGE_ALSA_LIB_TOPOLOGY
 
 config BR2_PACKAGE_ALSA_UTILS_AMIDI
 	bool "amidi"
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/alsa-utils: update dependency for topology support

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Sat,  5 Nov 2022 08:44:44 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

>  config BR2_PACKAGE_ALSA_UTILS_ALSATPLG
>  	bool "alsatplg"
> -	depends on !BR2_STATIC_LIBS # dlfcn.h
> -
> -comment "alsatplg needs a toolchain w/ dynamic library"
> -	depends on BR2_STATIC_LIBS
> +	depends on BR2_PACKAGE_ALSA_LIB_TOPOLOGY

I'm wondering why you're doing it like this, and not in the normal way:

config BR2_PACKAGE_ALSA_UTILS_ALSATPLG
        bool "alsatplg"
        depends on !BR2_STATIC_LIBS # alsa-lib topology
	select BR2_PACKAGE_ALSA_LIB_TOPOLOGY

comment "alsatplg needs a toolchain w/ dynamic library"
        depends on BR2_STATIC_LIBS

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot