Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] Makefile: unexport PERL_MM_OPT
@ 2022-11-06 14:26 Gleb Mazovetskiy
  2022-11-07 22:10 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Gleb Mazovetskiy @ 2022-11-06 14:26 UTC (permalink / raw)
  To: buildroot; +Cc: Gleb Mazovetskiy

Compilation of Perl-related packages fails if `PERL_MM_OPT` is defined.

We previously issued an error in this case.
Instead, simply `unexport` the variable.

Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
---
 Makefile                             | 3 +++
 support/dependencies/dependencies.sh | 9 ---------
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/Makefile b/Makefile
index 7c1c07a2e4..71b622474f 100644
--- a/Makefile
+++ b/Makefile
@@ -396,6 +396,9 @@ unexport DESTDIR
 # Causes breakage with packages that needs host-ruby
 unexport RUBYOPT
 
+# Compilation of perl-related packages will fail otherwise
+unexport PERL_MM_OPT
+
 include package/pkg-utils.mk
 include package/doc-asciidoc.mk
 
diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index 2b678ae8c4..4b5012b807 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -46,15 +46,6 @@ case ":${PATH:-unset}:" in
 	;;
 esac
 
-if test -n "$PERL_MM_OPT" ; then
-	echo
-	echo "You have PERL_MM_OPT defined because Perl local::lib"
-	echo "is installed on your system. Please unset this variable"
-	echo "before starting Buildroot, otherwise the compilation of"
-	echo "Perl related packages will fail"
-	exit 1
-fi
-
 check_prog_host()
 {
 	prog="$1"
-- 
2.37.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] Makefile: unexport PERL_MM_OPT
  2022-11-06 14:26 [Buildroot] [PATCH 1/1] Makefile: unexport PERL_MM_OPT Gleb Mazovetskiy
@ 2022-11-07 22:10 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-11-07 22:10 UTC (permalink / raw)
  To: Gleb Mazovetskiy; +Cc: buildroot

On Sun,  6 Nov 2022 14:26:34 +0000
Gleb Mazovetskiy <glex.spb@gmail.com> wrote:

> Compilation of Perl-related packages fails if `PERL_MM_OPT` is defined.
> 
> We previously issued an error in this case.
> Instead, simply `unexport` the variable.
> 
> Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
> ---
>  Makefile                             | 3 +++
>  support/dependencies/dependencies.sh | 9 ---------
>  2 files changed, 3 insertions(+), 9 deletions(-)

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-07 22:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-06 14:26 [Buildroot] [PATCH 1/1] Makefile: unexport PERL_MM_OPT Gleb Mazovetskiy
2022-11-07 22:10 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox