[Buildroot] [PATCH 1/1] package/lxc: add systemd optional dependency

[Buildroot] [PATCH 1/1] package/lxc: add systemd optional dependency

[Fabrice Fontaine]

Fix the following build failure raised since bump to version 5.0.1 in
commit db19998035701d08bf1b5fd366e0b5aa9adb8e57:

Run-time dependency systemd found: NO (tried pkgconfig and cmake)

../output-1/build/lxc-5.0.1/config/init/systemd/meson.build:11:4: ERROR: Dependency "systemd" not found, tried pkgconfig and cmake

Fixes:
 - http://autobuild.buildroot.org/results/495175c367084093bc01c40290736c738d876894

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/lxc/lxc.mk | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/package/lxc/lxc.mk b/package/lxc/lxc.mk
index f0a0e8041a..e1639c5f15 100644
--- a/package/lxc/lxc.mk
+++ b/package/lxc/lxc.mk
@@ -63,4 +63,19 @@ else
 LXC_CONF_OPTS += -Dopenssl=false
 endif
 
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+LXC_CONF_OPTS += -Dsd-bus=enabled
+LXC_DEPENDENCIES += systemd
+else
+LXC_CONF_OPTS += -Dsd-bus=disabled
+endif
+
+ifeq ($(BR2_INIT_SYSTEMD),y)
+LXC_CONF_OPTS += -Dinit-script=systemd
+else ifeq ($(BR2_INIT_SYSV),y)
+LXC_CONF_OPTS += -Dinit-script=sysvinit
+else
+LXC_CONF_OPTS += -Dinit-script=
+endif
+
 $(eval $(meson-package))
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/lxc: add systemd optional dependency

[Thomas Petazzoni via buildroot]

On Sun,  6 Nov 2022 16:38:03 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure raised since bump to version 5.0.1 in
> commit db19998035701d08bf1b5fd366e0b5aa9adb8e57:
> 
> Run-time dependency systemd found: NO (tried pkgconfig and cmake)
> 
> ../output-1/build/lxc-5.0.1/config/init/systemd/meson.build:11:4: ERROR: Dependency "systemd" not found, tried pkgconfig and cmake
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/495175c367084093bc01c40290736c738d876894
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---

Applied to master... but...

> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +LXC_CONF_OPTS += -Dsd-bus=enabled
> +LXC_DEPENDENCIES += systemd
> +else
> +LXC_CONF_OPTS += -Dsd-bus=disabled
> +endif
> +
> +ifeq ($(BR2_INIT_SYSTEMD),y)
> +LXC_CONF_OPTS += -Dinit-script=systemd
> +else ifeq ($(BR2_INIT_SYSV),y)
> +LXC_CONF_OPTS += -Dinit-script=sysvinit

What is this doing exactly? Should it also be set for BR2_INIT_BUSYBOX,
which also uses sysv-style init scripts? Is the init script provided by
LXC actually usable in the context of Buildroot?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot