[Buildroot] [PATCH] package/imagemagick: utilities now need C++ support

[Buildroot] [PATCH] package/imagemagick: utilities now need C++ support

[Thomas Petazzoni via buildroot]

Since upstream commit
https://github.com/ImageMagick/ImageMagick/commit/07f3b487f9860fd4eb9422f1a906d0fe83b6fd1c
(which first appeared in version 7.1.0-47), ImageMagick forces the
need of a C++ compiler to build its utilities. Despite the request of
Bernd Kuhls to revert this change, upstream declined.

Since this change is causing build failures in our autobuilders, our
only choice is to follow the choice of upstream, and disable building
the utilities when C++ support is not available.

Fixes:

  http://autobuild.buildroot.net/results/4283235d697408cf2e70be5e3769dbe6ebb9ddae/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/imagemagick/imagemagick.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
index 6bdf24c1e8..8a2ec460d5 100644
--- a/package/imagemagick/imagemagick.mk
+++ b/package/imagemagick/imagemagick.mk
@@ -178,6 +178,12 @@ else
 IMAGEMAGICK_CONF_OPTS += --without-bzlib
 endif
 
+ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
+IMAGEMAGICK_CONF_OPTS += --with-utilities
+else
+IMAGEMAGICK_CONF_OPTS += --without-utilities
+endif
+
 HOST_IMAGEMAGICK_CONF_OPTS = \
 	--disable-opencl \
 	--disable-openmp \
-- 
2.38.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/imagemagick: utilities now need C++ support

[Yann E. MORIN]

Thomas, All,

On 2022-11-11 23:40 +0100, Thomas Petazzoni via buildroot spake thusly:
> Since upstream commit
> https://github.com/ImageMagick/ImageMagick/commit/07f3b487f9860fd4eb9422f1a906d0fe83b6fd1c
> (which first appeared in version 7.1.0-47), ImageMagick forces the
> need of a C++ compiler to build its utilities. Despite the request of
> Bernd Kuhls to revert this change, upstream declined.
> 
> Since this change is causing build failures in our autobuilders, our
> only choice is to follow the choice of upstream, and disable building
> the utilities when C++ support is not available.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/4283235d697408cf2e70be5e3769dbe6ebb9ddae/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/imagemagick/imagemagick.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
> index 6bdf24c1e8..8a2ec460d5 100644
> --- a/package/imagemagick/imagemagick.mk
> +++ b/package/imagemagick/imagemagick.mk
> @@ -178,6 +178,12 @@ else
>  IMAGEMAGICK_CONF_OPTS += --without-bzlib
>  endif
>  
> +ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
> +IMAGEMAGICK_CONF_OPTS += --with-utilities
> +else
> +IMAGEMAGICK_CONF_OPTS += --without-utilities
> +endif
> +
>  HOST_IMAGEMAGICK_CONF_OPTS = \
>  	--disable-opencl \
>  	--disable-openmp \
> -- 
> 2.38.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/imagemagick: utilities now need C++ support

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > Since upstream commit
 > https://github.com/ImageMagick/ImageMagick/commit/07f3b487f9860fd4eb9422f1a906d0fe83b6fd1c
 > (which first appeared in version 7.1.0-47), ImageMagick forces the
 > need of a C++ compiler to build its utilities. Despite the request of
 > Bernd Kuhls to revert this change, upstream declined.

 > Since this change is causing build failures in our autobuilders, our
 > only choice is to follow the choice of upstream, and disable building
 > the utilities when C++ support is not available.

 > Fixes:

 >   http://autobuild.buildroot.net/results/4283235d697408cf2e70be5e3769dbe6ebb9ddae/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2022.08.x and 2022.02.x, thanks.

Is imagemagick without the utilities useful?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/imagemagick: utilities now need C++ support

[Thomas Petazzoni via buildroot]

On Tue, 15 Nov 2022 14:01:03 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

> Is imagemagick without the utilities useful?

It has a library. Not sure how widely used it is, though. dvdauthor,
libvips, php-imagick have it as a build time dependency, so I suppose
(but didn't check) that they link with the library.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot