Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: "Frager, Neal" <neal.frager@amd.com>,
	"Frager, Neal via buildroot" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support
Date: Tue, 22 Nov 2022 19:07:43 +0100	[thread overview]
Message-ID: <20221122190743.2610e8e9@booty> (raw)
In-Reply-To: <20221122171315.7a749d61@windsurf>

Hello Thomas,

On Tue, 22 Nov 2022 17:13:15 +0100
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello Neal,
> 
> On Tue, 22 Nov 2022 09:43:45 +0000
> "Frager, Neal via buildroot" <buildroot@buildroot.org> wrote:
> 
> > Perhaps just checking every file for existence when running the loop below is the best option like below.  The idea is to keep this as simple as possible.  What do you think?
> > 
> > define UBOOT_INSTALL_IMAGES_CMDS
> > 	$(foreach f,$(UBOOT_BINS), \
> > 			$(if test -f $(@D)/$(f), \
> > 			cp -dpf $(@D)/$(f) $(BINARIES_DIR))/
> > 	)  
> 
> I think we should change:
> 
> config BR2_TARGET_UBOOT_FORMAT_ELF
>         bool "u-boot.elf"
> 
> to:
> 
> config BR2_TARGET_UBOOT_FORMAT_ELF
>         bool "u-boot"
> 
> (because this is really what it is doing)

Right.

> 
> and then introduce:
> 
> config BR2_TARGET_UBOOT_FORMAT_ELF_STRIPPED
>         bool "u-boot.elf"
> 
> which installs the stripped u-boot.elf file.
> 
> This way, BR2_TARGET_UBOOT_FORMAT_ELF_STRIPPED can be enabled on
> configurations that need it, without breaking configurations that
> provide u-boot but not u-boot.elf.

I agree with the principle you are proposing.

However, according to the U-Boot source code, u-boot.elf appears as
u-boot.bin repackaged into an ELF file. Is "stripped" a correct word
for this?

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-11-22 18:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  5:36 [Buildroot] [PATCH v2 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support Neal Frager via buildroot
2022-11-22  9:01 ` Luca Ceresoli via buildroot
2022-11-22  9:43   ` Frager, Neal via buildroot
2022-11-22 16:13     ` Thomas Petazzoni via buildroot
2022-11-22 18:07       ` Luca Ceresoli via buildroot [this message]
2022-11-22 20:47         ` Thomas Petazzoni via buildroot
2022-11-22 21:31           ` Luca Ceresoli via buildroot
2022-11-23  0:09             ` Frager, Neal via buildroot
2022-11-23 13:31               ` Thomas Petazzoni via buildroot
2022-11-23 14:06                 ` Frager, Neal via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221122190743.2610e8e9@booty \
    --to=buildroot@buildroot.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=neal.frager@amd.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox