Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Frager, Neal" <neal.frager@amd.com>
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	"Frager, Neal via buildroot" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support
Date: Wed, 23 Nov 2022 14:31:40 +0100	[thread overview]
Message-ID: <20221123143140.004746c3@windsurf> (raw)
In-Reply-To: <CH2PR12MB500483D91AC77B29445F4B1EF00C9@CH2PR12MB5004.namprd12.prod.outlook.com>

Hello Neal,

On Wed, 23 Nov 2022 00:09:39 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:

> I am not sure creating a separate BR2 config is the right solution.
> Both the u-boot and u-boot.elf file are in fact elf formatted files.
> One just has all the debug symbols and one does not.

I don't understand why you think having a separate option is a problem.
We already have separate options for each file that can be installed by
U-Boot. Adding another option for another file is completely logical,
and actually much more logical than having a weird option that
magically installs 2 files - sometimes.

> What do you think of this solution?  Basically, we check that the
> file exists before copying.  It is probably good to have this check
> anyway.

Checks like this are actually not great, because you expect something
to happen, there is no error, but the thing you were expecting did not
happen. Clearly confusing for the user.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-11-23 13:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  5:36 [Buildroot] [PATCH v2 1/1] boot/uboot/uboot.mk: add stripped u-boot.elf support Neal Frager via buildroot
2022-11-22  9:01 ` Luca Ceresoli via buildroot
2022-11-22  9:43   ` Frager, Neal via buildroot
2022-11-22 16:13     ` Thomas Petazzoni via buildroot
2022-11-22 18:07       ` Luca Ceresoli via buildroot
2022-11-22 20:47         ` Thomas Petazzoni via buildroot
2022-11-22 21:31           ` Luca Ceresoli via buildroot
2022-11-23  0:09             ` Frager, Neal via buildroot
2022-11-23 13:31               ` Thomas Petazzoni via buildroot [this message]
2022-11-23 14:06                 ` Frager, Neal via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123143140.004746c3@windsurf \
    --to=buildroot@buildroot.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=neal.frager@amd.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox