Re: [Buildroot] [PATCH v2 2/3] package/monero: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Bernd,

Thanks for the contribution. See below some comments.

On Mon, 31 Oct 2022 20:52:04 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: disabled support for BR2_aarch64_be, not supported upstream:
>     https://github.com/tevador/RandomX/pull/257

What this pull requests says is "The current implementation of JIT
won't work on big endian processors.". So the problem seems to not be
with just AArch64 BE, but all big endian architectures, no? If so,
should this be depends on BR2_ENDIAN != "BIG" ? (With a comment above it).

Curious: what is the use case of a cryptocurrency stuff in Buildroot?


> diff --git a/package/monero/0001-disable-stack-protector.patch b/package/monero/0001-disable-stack-protector.patch
> new file mode 100644
> index 0000000000..0407b4e32d
> --- /dev/null
> +++ b/package/monero/0001-disable-stack-protector.patch
> @@ -0,0 +1,22 @@
> +Disable unconditional stack-protector support
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

They're using Git upstream, so please use Git-formatted patches.

Has this been submitted upstream, for example by making SSP optional?

> diff --git a/package/monero/0002-system-miniupnpc.patch b/package/monero/0002-system-miniupnpc.patch
> new file mode 100644
> index 0000000000..e12d9302bd
> --- /dev/null
> +++ b/package/monero/0002-system-miniupnpc.patch
> @@ -0,0 +1,112 @@
> +Add support for miniupnpc system library
> +
> +Downloaded from
> +https://git.alpinelinux.org/aports/plain/community/monero/system-miniupnpc.patch
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

It also needs to be Git formatted.

Has this been submitted upstream?


> diff --git a/package/monero/Config.in b/package/monero/Config.in
> new file mode 100644
> index 0000000000..59036286cd
> --- /dev/null
> +++ b/package/monero/Config.in
> @@ -0,0 +1,35 @@
> +config BR2_PACKAGE_MONERO
> +	bool "monero"
> +	depends on !BR2_aarch64_be && !BR2_i386

Why is i386 excluded?


> +MONERO_VERSION = 0.18.1.2
> +MONERO_SOURCE = monero-source-v$(MONERO_VERSION).tar.bz2
> +MONERO_SITE = https://downloads.getmonero.org/cli
> +MONERO_LICENSE = MIT
> +MONERO_LICENSE_FILES = LICENSE
> +MONERO_CONF_OPTS = \
> +	-DBUILD_DOCUMENTATION=OFF \
> +	-DCMAKE_CXX_FLAGS="$(MONERO_CXXFLAGS)" \
> +	-DCMAKE_BUILD_TYPE=None \

Is that normal?

> +	-DMANUAL_SUBMODULES=ON \
> +	-DSTACK_TRACE=OFF \
> +	-DUSE_CCACHE=OFF \
> +	-DUSE_DEVICE_TREZOR=OFF
> +MONERO_DEPENDENCIES = \
> +	boost \
> +	czmq \
> +	libminiupnpc \
> +	libsodium \
> +	openssl \
> +	unbound
> +
> +ifeq ($(BR2_aarch64_be)$(BR2_mips)$(BR2_mipsel)$(BR2_mips64el)$(BR2_sparc64),y)

So you don't support AArch64 BE, but it's handled here ? :-)

> +MONERO_CONF_OPTS += -DNO_AES=ON
> +endif

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot