Re: [Buildroot] [PATCH v2 3/3] package/p2pool: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Mon, 31 Oct 2022 20:52:05 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v2: disabled support for BR2_aarch64_be, not supported upstream:
>     https://github.com/tevador/RandomX/pull/257

Same comment as for monero, is this about AArch64 BE, or all BE
architectures?

> diff --git a/package/p2pool/Config.in b/package/p2pool/Config.in
> new file mode 100644
> index 0000000000..53f894e309
> --- /dev/null
> +++ b/package/p2pool/Config.in
> @@ -0,0 +1,27 @@
> +config BR2_PACKAGE_P2POOL
> +	bool "p2pool"
> +	depends on BR2_ARCH_IS_64
> +	depends on !BR2_aarch64_be

This package is not selecting monero, so why should it inherit its
dependencies? Or this RandomX thing is a library that is bundled in
both monero and p2pool?

> +# prevent compiler warnings being treated as errors
> +define P2POOL_REMOVE_WARNING_FLAGS
> +	$(SED) '/set(WARNING_FLAGS/d' $(@D)/cmake/flags.cmake
> +endef
> +P2POOL_POST_PATCH_HOOKS += P2POOL_REMOVE_WARNING_FLAGS

Is an upstreamable patch possible for this?

Thanks

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot