Re: [Buildroot] [PATCH 7/7] package: optee-client: fix identation issues

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Etienne, All,

On 2022-11-30 08:54 +0100, Etienne Carriere spake thusly:
> Fix issues reported by utils/check-package:
> package/optee-client/S30optee:40: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
> package/optee-client/S30optee:46: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
> package/optee-client/S30optee:47: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)
> package/optee-client/S30optee:48: should be indented with tabs (http://nightly.buildroot.org/#adding-packages-start-script)

I also had:

    package/optee-client/S30optee:0: filename should be S<number><number><daemon name> (http://nightly.buildroot.org/#adding-packages-start-script)
    package/optee-client/S30tee-supplicant:0: run 'shellcheck' and fix the warnings

So I also fixed those and applied to master, thanks.

Since those are fixes for existing issues, it should come early in the
series. I.e. a series should first fix issues, then add features (like
bumping a version).

That way, fixes can be applied early even if the rest of the series has
issues, and they can also more easily be backported as they do not
depend on the previous feature patches (in this case the fix applied
cleanly, but that's not always the case).

Regards,
Yann E. MORIN.

> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
>  package/optee-client/S30optee | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/optee-client/S30optee b/package/optee-client/S30optee
> index 17e6d6d2b8..abb7e77afe 100644
> --- a/package/optee-client/S30optee
> +++ b/package/optee-client/S30optee
> @@ -37,13 +37,13 @@ restart() {
>  }
>  
>  case "$1" in
> -        start|stop|restart)
> +	start|stop|restart)
>  		"$1";;
>  	reload)
>  		# Restart, since there is no true "reload" feature (does not
>  		# reconfigure/restart on SIGHUP, just closes all open files).
>  		restart;;
> -        *)
> -                echo "Usage: $0 {start|stop|restart|reload}"
> -                exit 1
> +	*)
> +		echo "Usage: $0 {start|stop|restart|reload}"
> +		exit 1
>  esac
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot