Re: [Buildroot] [PATCH 6/7] package: optee-client: select util-linux-libs, libuuid and pkgconf

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Etienne Carriere <etienne.carriere@linaro.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 6/7] package: optee-client: select util-linux-libs, libuuid and pkgconf
Date: Sun, 4 Dec 2022 12:17:22 +0100	[thread overview]
Message-ID: <20221204111722.GK3302@scaer> (raw)
In-Reply-To: <20221130075452.2507453-6-etienne.carriere@linaro.org>

Etienne, All,

On 2022-11-30 08:54 +0100, Etienne Carriere spake thusly:
> In order to use login methods `TEEC_LOGIN_USER` and `TEEC_LOGIN_GROUP`,
> a user space application must initialize the tokens with the SHA1
> hashed UUID of the user or group.
> 
> Select host-pkgconf, util-linux and libuuid in order to use `libuuid`
> and add supporting libraries to optee_client for this type of ACL based
> login initialization.

Looking at the upstream code for optee-client, it looks like this is a
mandatory dependency, so that should be part of the patch that bumps the
version. Otherwise, this means that just applying the version bumps
introduces breakage.

Regards,
Yann E. MORIN.

> This change is based on commit [1] from Eero Aaltonen, merged in OP-TEE
> test build environment.
> 
> Link: [1] https://github.com/OP-TEE/build/commit/4a27543494278a5d93e2f44d58e413d90739b08a
> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
> ---
>  package/optee-client/Config.in       | 3 +++
>  package/optee-client/optee-client.mk | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/package/optee-client/Config.in b/package/optee-client/Config.in
> index cc7f176c77..ed7da4edbc 100644
> --- a/package/optee-client/Config.in
> +++ b/package/optee-client/Config.in
> @@ -2,6 +2,9 @@ config BR2_PACKAGE_OPTEE_CLIENT
>  	bool "optee-client"
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_3 # MMC_IOC_MULTI_CMD
> +	select BR2_PACKAGE_UTIL_LINUX
> +	select BR2_PACKAGE_UTIL_LINUX_LIBS
> +	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
>  	help
>  	  Enable the OP-TEE client package that brings non-secure
>  	  client application resources for OP-TEE support. OP-TEE
> diff --git a/package/optee-client/optee-client.mk b/package/optee-client/optee-client.mk
> index 54cc112c5c..a671b66662 100644
> --- a/package/optee-client/optee-client.mk
> +++ b/package/optee-client/optee-client.mk
> @@ -9,6 +9,7 @@ OPTEE_CLIENT_SITE = $(call github,OP-TEE,optee_client,$(OPTEE_CLIENT_VERSION))
>  OPTEE_CLIENT_LICENSE = BSD-2-Clause
>  OPTEE_CLIENT_LICENSE_FILES = LICENSE
>  OPTEE_CLIENT_INSTALL_STAGING = YES
> +OPTEE_CLIENT_EXT_DEPENDENCIES = host-pkgconf util-linux-libs
>  
>  OPTEE_CLIENT_CONF_OPTS = \
>  	-DCFG_TEE_FS_PARENT_PATH=$(BR2_PACKAGE_OPTEE_CLIENT_TEE_FS_PATH) \
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot