From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Paul Cercueil <paul@crapouillou.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/lightning; fix build
Date: Tue, 20 Dec 2022 14:14:00 +0100 [thread overview]
Message-ID: <20221220131400.GG2909@scaer> (raw)
In-Reply-To: <CAPi7W83Fmd2ijRsCwpSfNf2YgRbE=yCDHTKgpKwxmg3Je3kkMQ@mail.gmail.com>
FAbrice, All,
On 2022-12-20 09:52 +0100, Fabrice Fontaine spake thusly:
> Le mar. 20 déc. 2022 à 09:47, Yann E. MORIN < [1]yann.morin.1998@free.fr> a écrit :
> On 2022-12-19 23:58 +0100, Fabrice Fontaine spake thusly:
> > Fix the following build failure raised since bump to version 2.2.0 in
> > commit af6f7aa76db5aed1eada0b27bd0375610a2fc728 and
[--SNIP--]
> > + #if BINUTILS_2_38
> > +-static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
> > ++static int fprintf_styled(void * stream, enum disassembler_style style, const char* fmt, ...)
> Should it be marked with __attribute__((unused)) or some such?
> Indeed, I'll send a v2.
And even beter yet: change the code to actually use the stream:
- r = vprintf(fmt, args);
+ r = vfprintf(stream, fmt, args);
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-12-20 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 22:58 [Buildroot] [PATCH 1/1] package/lightning; fix build Fabrice Fontaine
2022-12-20 8:47 ` Yann E. MORIN
2022-12-20 8:52 ` Fabrice Fontaine
2022-12-20 13:14 ` Yann E. MORIN [this message]
2022-12-21 12:49 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220131400.GG2909@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox