Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Paul Cercueil <paul@crapouillou.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/lightning; fix build
Date: Wed, 21 Dec 2022 13:49:55 +0100	[thread overview]
Message-ID: <20221221124955.GL2909@scaer> (raw)
In-Reply-To: <20221219225820.429460-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2022-12-19 23:58 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since bump to version 2.2.0 in
> commit af6f7aa76db5aed1eada0b27bd0375610a2fc728 and
> http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=837c7a1e8d08fb9294578dc84694077f4d6106f9:
> 
> jit_disasm.c: In function 'fprintf_styled':
> jit_disasm.c:57:27: error: parameter name omitted
>    57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
>       |                           ^~~~~~
> jit_disasm.c:57:35: error: parameter name omitted
>    57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
>       |                                   ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e15e01e98e0d8c873efd3f512b671d98e4daf6c0
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  .../0001-lib-jit_disasm.c-fix-build.patch     | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> 
> diff --git a/package/lightning/0001-lib-jit_disasm.c-fix-build.patch b/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> new file mode 100644
> index 0000000000..f0bedc1817
> --- /dev/null
> +++ b/package/lightning/0001-lib-jit_disasm.c-fix-build.patch
> @@ -0,0 +1,41 @@
> +From 6d3ba4fb38ef3af61d8b7fc5c7781ed244ccf9fe Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Mon, 19 Dec 2022 23:36:48 +0100
> +Subject: [PATCH] lib/jit_disasm.c: fix build
> +
> +Fix the following build failure raised since
> +http://git.savannah.gnu.org/cgit/lightning.git/commit/?id=837c7a1e8d08fb9294578dc84694077f4d6106f9:
> +
> +jit_disasm.c: In function 'fprintf_styled':
> +jit_disasm.c:57:27: error: parameter name omitted
> +   57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
> +      |                           ^~~~~~
> +jit_disasm.c:57:35: error: parameter name omitted
> +   57 | static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
> +      |                                   ^~~~~~~~~~~~~~~~~~~~~~~
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/e15e01e98e0d8c873efd3f512b671d98e4daf6c0
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status: sent to lightning@gnu.org]

Although I think we could have been a better fix, this has now been
applied upstream, so we can just argue that any remaining issue will
have to be fixed with another (set of) patches.

Applied to master after making it a proper backport, thanks.

Regards,
Yann E. MORIN.

> +---
> + lib/jit_disasm.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/lib/jit_disasm.c b/lib/jit_disasm.c
> +index 58a269b..68c966d 100644
> +--- a/lib/jit_disasm.c
> ++++ b/lib/jit_disasm.c
> +@@ -54,7 +54,7 @@ static FILE			 *disasm_stream;
> + #endif
> + 
> + #if BINUTILS_2_38
> +-static int fprintf_styled(void *, enum disassembler_style, const char* fmt, ...)
> ++static int fprintf_styled(void * stream, enum disassembler_style style, const char* fmt, ...)
> + {
> +   va_list args;
> +   int r;
> +-- 
> +2.35.1
> +
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-12-21 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 22:58 [Buildroot] [PATCH 1/1] package/lightning; fix build Fabrice Fontaine
2022-12-20  8:47 ` Yann E. MORIN
2022-12-20  8:52   ` Fabrice Fontaine
2022-12-20 13:14     ` Yann E. MORIN
2022-12-21 12:49 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221221124955.GL2909@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=paul@crapouillou.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox