[Buildroot] [PATCH 1/1] package/xxhash: set XXH_NO_INLINE_HINTS

[Buildroot] [PATCH 1/1] package/xxhash: set XXH_NO_INLINE_HINTS

[Fabrice Fontaine]

Set XXH_NO_INLINE_HINTS to marks all internal functions as static,
giving the compiler full control on whether to inline or not. This will
fix the following build failure raised since bump to version 0.8.1 in
commit 5dbdb2535c649ee617595b8c4ae3cbba0ee37b97:

In file included from xxhash.c:43:
In function 'XXH3_accumulate',
    inlined from 'XXH3_hashLong_internal_loop' at xxhash.h:4390:9,
    inlined from 'XXH3_hashLong_64b_internal' at xxhash.h:4453:5,
    inlined from 'XXH3_hashLong_64b_withSecret' at xxhash.h:4473:12,
    inlined from 'XXH3_64bits_internal' at xxhash.h:4554:12,
    inlined from 'XXH3_64bits_withSecret' at xxhash.h:4570:12:
xxhash.h:4196:1: error: inlining failed in call to 'always_inline' 'XXH3_accumulate_512_scalar': function not considered for inlining
 4196 | XXH3_accumulate_512_scalar(void* XXH_RESTRICT acc,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/f2c52238df97cc4c13117d8dc1423235231a094c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/xxhash/xxhash.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/xxhash/xxhash.mk b/package/xxhash/xxhash.mk
index 04bc98690f..40e3c2696c 100644
--- a/package/xxhash/xxhash.mk
+++ b/package/xxhash/xxhash.mk
@@ -28,6 +28,7 @@ endif
 
 define XXHASH_BUILD_CMDS
 	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		CFLAGS="$(TARGET_CFLAGS) -DXXH_NO_INLINE_HINTS" \
 		$(XXHASH_TARGETS)
 endef
 
-- 
2.39.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/xxhash: set XXH_NO_INLINE_HINTS

[Yann E. MORIN]

Fabrice, All,

On 2023-01-18 19:23 +0100, Fabrice Fontaine spake thusly:
> Set XXH_NO_INLINE_HINTS to marks all internal functions as static,
> giving the compiler full control on whether to inline or not. This will
> fix the following build failure raised since bump to version 0.8.1 in
> commit 5dbdb2535c649ee617595b8c4ae3cbba0ee37b97:
> 
> In file included from xxhash.c:43:
> In function 'XXH3_accumulate',
>     inlined from 'XXH3_hashLong_internal_loop' at xxhash.h:4390:9,
>     inlined from 'XXH3_hashLong_64b_internal' at xxhash.h:4453:5,
>     inlined from 'XXH3_hashLong_64b_withSecret' at xxhash.h:4473:12,
>     inlined from 'XXH3_64bits_internal' at xxhash.h:4554:12,
>     inlined from 'XXH3_64bits_withSecret' at xxhash.h:4570:12:
> xxhash.h:4196:1: error: inlining failed in call to 'always_inline' 'XXH3_accumulate_512_scalar': function not considered for inlining
>  4196 | XXH3_accumulate_512_scalar(void* XXH_RESTRICT acc,
>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/f2c52238df97cc4c13117d8dc1423235231a094c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/xxhash/xxhash.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/xxhash/xxhash.mk b/package/xxhash/xxhash.mk
> index 04bc98690f..40e3c2696c 100644
> --- a/package/xxhash/xxhash.mk
> +++ b/package/xxhash/xxhash.mk
> @@ -28,6 +28,7 @@ endif
>  
>  define XXHASH_BUILD_CMDS
>  	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
> +		CFLAGS="$(TARGET_CFLAGS) -DXXH_NO_INLINE_HINTS" \
>  		$(XXHASH_TARGETS)
>  endef
>  
> -- 
> 2.39.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/xxhash: set XXH_NO_INLINE_HINTS

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Set XXH_NO_INLINE_HINTS to marks all internal functions as static,
 > giving the compiler full control on whether to inline or not. This will
 > fix the following build failure raised since bump to version 0.8.1 in
 > commit 5dbdb2535c649ee617595b8c4ae3cbba0ee37b97:

 > In file included from xxhash.c:43:
 > In function 'XXH3_accumulate',
 >     inlined from 'XXH3_hashLong_internal_loop' at xxhash.h:4390:9,
 >     inlined from 'XXH3_hashLong_64b_internal' at xxhash.h:4453:5,
 >     inlined from 'XXH3_hashLong_64b_withSecret' at xxhash.h:4473:12,
 >     inlined from 'XXH3_64bits_internal' at xxhash.h:4554:12,
 >     inlined from 'XXH3_64bits_withSecret' at xxhash.h:4570:12:
 > xxhash.h:4196:1: error: inlining failed in call to 'always_inline' 'XXH3_accumulate_512_scalar': function not considered for inlining
 >  4196 | XXH3_accumulate_512_scalar(void* XXH_RESTRICT acc,
 >       | ^~~~~~~~~~~~~~~~~~~~~~~~~~

 > Fixes:
 >  - http://autobuild.buildroot.org/results/f2c52238df97cc4c13117d8dc1423235231a094c

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.11.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot