Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Buildroot <buildroot@buildroot.org>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
	Matt Weber <matthew.weber@collins.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: [Buildroot] [PATCH] package/git: prefer OpenSSL SHA-1 and SHA-256 implementation
Date: Thu, 19 Jan 2023 16:58:42 +0700	[thread overview]
Message-ID: <20230119095842.445227-1-bagasdotme@gmail.com> (raw)

Git is shipped with its own implementation of SHA-1 and SHA-256.
However, when OpenSSL is available (BR2_PACKAGE_OPENSSL=y), it is
preferable to leverage the OpenSSL version of these hash algorithm
instead. --with-openssl configure flag doesn't enable that, though.

Set OPENSSL_{SHA1,SHA256} make variable when OpenSSL package is
selected.

Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
 package/git/git.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/git/git.mk b/package/git/git.mk
index 9918d4c1ef..916ccc0cf3 100644
--- a/package/git/git.mk
+++ b/package/git/git.mk
@@ -16,7 +16,9 @@ GIT_DEPENDENCIES = zlib $(TARGET_NLS_DEPENDENCIES)
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 GIT_DEPENDENCIES += host-pkgconf openssl
 GIT_CONF_OPTS += --with-openssl
-GIT_MAKE_OPTS += LIB_4_CRYPTO="`$(PKG_CONFIG_HOST_BINARY) --libs libssl libcrypto`"
+GIT_MAKE_OPTS += \
+	LIB_4_CRYPTO="`$(PKG_CONFIG_HOST_BINARY) --libs libssl libcrypto`" \
+	OPENSSL_SHA1=YesPlease OPENSSL_SHA256=YesPlease
 else
 GIT_CONF_OPTS += --without-openssl
 endif

base-commit: c77c66b7df478f508b8f2affa7a64795504db699
-- 
An old man doll... just what I always wanted! - Clara

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2023-01-19  9:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19  9:58 Bagas Sanjaya [this message]
2023-01-19 10:04 ` [Buildroot] [PATCH] package/git: prefer OpenSSL SHA-1 and SHA-256 implementation Peter Korsgaard
2023-01-19 20:35   ` Peter Seiderer
2023-01-20  2:35     ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230119095842.445227-1-bagasdotme@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=matthew.weber@collins.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox