From: Peter Korsgaard <peter@korsgaard.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Matt Weber <matthew.weber@collins.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/git: prefer OpenSSL SHA-1 and SHA-256 implementation
Date: Thu, 19 Jan 2023 11:04:13 +0100 [thread overview]
Message-ID: <87cz7aden6.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20230119095842.445227-1-bagasdotme@gmail.com> (Bagas Sanjaya's message of "Thu, 19 Jan 2023 16:58:42 +0700")
>>>>> "Bagas" == Bagas Sanjaya <bagasdotme@gmail.com> writes:
> Git is shipped with its own implementation of SHA-1 and SHA-256.
> However, when OpenSSL is available (BR2_PACKAGE_OPENSSL=y), it is
> preferable to leverage the OpenSSL version of these hash algorithm
> instead. --with-openssl configure flag doesn't enable that, though.
> Set OPENSSL_{SHA1,SHA256} make variable when OpenSSL package is
> selected.
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
What is the added value of doing this? Size? Speed? Why is it not the
upstream default?
A quick search for git + OPENSSL_SHA1 lead me to:
https://www.spinics.net/lists/git/msg125401.html
Which is old, but argued for not using the openssl implementation
because of performance concerns.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-01-19 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 9:58 [Buildroot] [PATCH] package/git: prefer OpenSSL SHA-1 and SHA-256 implementation Bagas Sanjaya
2023-01-19 10:04 ` Peter Korsgaard [this message]
2023-01-19 20:35 ` Peter Seiderer
2023-01-20 2:35 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz7aden6.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=bagasdotme@gmail.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=matthew.weber@collins.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox