Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: michal.simek@amd.com, thomas.petazzoni@bootlin.com,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs
Date: Tue, 24 Jan 2023 09:18:50 +0100	[thread overview]
Message-ID: <20230124091850.0cabaa3e@booty> (raw)
In-Reply-To: <20221215111831.11956-1-neal.frager@amd.com>

Hi Neal,

On Thu, 15 Dec 2022 11:18:31 +0000
Neal Frager <neal.frager@amd.com> wrote:

> Reduce the configs in the kria/uboot.fragment to only what is necessary.
> 
> This patch has been build and run tested on a kria kv260 starter kit.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

Apologies for the delay. I was hoping to test this patch, but I'm not
yet there, so for the moment I have a question below.

> ---
> V1->V2:
>   - CONFIG_DTB_RESELECT is no longer removed
> ---
>  board/zynqmp/kria/uboot.fragment | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/board/zynqmp/kria/uboot.fragment b/board/zynqmp/kria/uboot.fragment
> index 9e32edfb36..a6a262a562 100644
> --- a/board/zynqmp/kria/uboot.fragment
> +++ b/board/zynqmp/kria/uboot.fragment
> @@ -6,9 +6,5 @@ CONFIG_PHY=y
>  CONFIG_PHY_XILINX_ZYNQMP=y
>  CONFIG_PINCTRL=y
>  CONFIG_PINCONF=y
> -CONFIG_POWER_DOMAIN=y
> -CONFIG_ZYNQMP_POWER_DOMAIN=y
> -CONFIG_DM_RESET=y
> -CONFIG_RESET_ZYNQMP=y

Does this prevent the 'reset' command in U-Boot from working?

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-01-24  8:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15 11:18 [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs Neal Frager via buildroot
2023-01-20 11:17 ` Frager, Neal via buildroot
2023-01-24  8:18 ` Luca Ceresoli via buildroot [this message]
2023-01-24  8:26   ` Frager, Neal via buildroot
2023-01-27  8:21     ` Luca Ceresoli via buildroot
2023-01-27  8:51       ` Frager, Neal via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230124091850.0cabaa3e@booty \
    --to=buildroot@buildroot.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=michal.simek@amd.com \
    --cc=neal.frager@amd.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox