Re: [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs

[Luca Ceresoli via buildroot <buildroot@buildroot.org>]

Hi Neal,

On Tue, 24 Jan 2023 08:26:27 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:

> Hi Luca,
> 
> > Reduce the configs in the kria/uboot.fragment to only what is necessary.
> > 
> > This patch has been build and run tested on a kria kv260 starter kit.
> > 
> > Signed-off-by: Neal Frager <neal.frager@amd.com>  
> 
> > Apologies for the delay. I was hoping to test this patch, but I'm not yet there, so for the moment I have a question below.  
> 
> No problem.
> 
> > ---
> > V1->V2:
> >   - CONFIG_DTB_RESELECT is no longer removed
> > ---
> >  board/zynqmp/kria/uboot.fragment | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/board/zynqmp/kria/uboot.fragment 
> > b/board/zynqmp/kria/uboot.fragment
> > index 9e32edfb36..a6a262a562 100644
> > --- a/board/zynqmp/kria/uboot.fragment
> > +++ b/board/zynqmp/kria/uboot.fragment
> > @@ -6,9 +6,5 @@ CONFIG_PHY=y
> >  CONFIG_PHY_XILINX_ZYNQMP=y
> >  CONFIG_PINCTRL=y
> >  CONFIG_PINCONF=y
> > -CONFIG_POWER_DOMAIN=y
> > -CONFIG_ZYNQMP_POWER_DOMAIN=y
> > -CONFIG_DM_RESET=y
> > -CONFIG_RESET_ZYNQMP=y  
> 
> > Does this prevent the 'reset' command in U-Boot from working?  
> 
> This patch actually has zero effect on functionality.  These 4 u-boot configs are already included in the xilinx_zynqmp_virt_defconfig.

I see, so the patch is fine. I would add the above line to the
commit message to make it clear. You can send a v3 unless some
maintainers is willing to do it while applying.

With that added:

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot