* [Buildroot] [PATCH 1/1] package/oatpp:: new package
@ 2023-01-28 9:41 Alessandro Partesotti
2023-01-29 17:11 ` Yann E. MORIN
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Alessandro Partesotti @ 2023-01-28 9:41 UTC (permalink / raw)
To: buildroot; +Cc: Alessandro Partesotti, Samuel Martin
This package introduce oatpp in BR buildsystem. oatpp must be used as static library in $(STAGING_DIR)/usr/include/oatpp-$(OATPP_VERSION)/oatpp for user that want to build therir own application by linking oatpp in a buildroot build system.
Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com>
---
package/Config.in | 3 +++
package/oatpp/Config.in | 14 ++++++++++++++
package/oatpp/oatpp.mk | 16 ++++++++++++++++
3 files changed, 33 insertions(+)
create mode 100644 package/oatpp/Config.in
create mode 100644 package/oatpp/oatpp.mk
diff --git a/package/Config.in b/package/Config.in
index 995dae2c57..481876a278 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1941,6 +1941,7 @@ menu "Networking"
source "package/nss-mdns/Config.in"
source "package/nss-myhostname/Config.in"
source "package/nss-pam-ldapd/Config.in"
+ source "package/oatpp/Config.in"
source "package/omniorb/Config.in"
source "package/open-isns/Config.in"
source "package/open62541/Config.in"
@@ -2702,4 +2703,6 @@ menu "Text editors and viewers"
source "package/vim/Config.in"
endmenu
+
endmenu
+
diff --git a/package/oatpp/Config.in b/package/oatpp/Config.in
new file mode 100644
index 0000000000..86eb4573a6
--- /dev/null
+++ b/package/oatpp/Config.in
@@ -0,0 +1,14 @@
+comment "Oat++ needs a toolchain w/ C++, threads and Paranoid Unsafe Path compiler flag disabled"
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || BR2_COMPILER_PARANOID_UNSAFE_PATH
+
+config BR2_PACKAGE_OATPP
+ bool "Oat++"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ depends on !BR2_COMPILER_PARANOID_UNSAFE_PATH
+ help
+ Oat++ is an open-source C++ web framework for highly scalable and resource-efficient web applications.
+ It provides all the necessary components for production-grade development.
+ This package allows you to use oatpp to statically build this a project inside the staging directory.
+ See https://oatpp.io/docs/start
+
diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk
new file mode 100644
index 0000000000..7abdeb6de5
--- /dev/null
+++ b/package/oatpp/oatpp.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# oatpp
+#
+################################################################################
+
+OATPP_VERSION= 1.3.0
+OATPP_SOURCE= $(OATPP_VERSION).tar.gz
+OATPP_SITE= https://github.com/oatpp/oatpp/archive/refs/tags
+#OATPP_SITE= git://github.com/oatpp/oatpp.git
+OATPP_INSTALL_STAGING= YES
+OATPP_INSTALL_TARGET= NO
+OATPP_MAKE=make
+
+$(eval $(cmake-package))
+
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/oatpp:: new package 2023-01-28 9:41 [Buildroot] [PATCH 1/1] package/oatpp:: new package Alessandro Partesotti @ 2023-01-29 17:11 ` Yann E. MORIN 2023-01-29 21:32 ` [Buildroot] [PATCH v2 " Alessandro Partesotti ` (2 subsequent siblings) 3 siblings, 0 replies; 9+ messages in thread From: Yann E. MORIN @ 2023-01-29 17:11 UTC (permalink / raw) To: Alessandro Partesotti; +Cc: Samuel Martin, buildroot Alessandro, All, Thanks for this patc; please find my review and comments below. On 2023-01-28 10:41 +0100, Alessandro Partesotti spake thusly: > This package introduce oatpp in BR buildsystem. oatpp must be used as static library in $(STAGING_DIR)/usr/include/oatpp-$(OATPP_VERSION)/oatpp for user that want to build therir own application by linking oatpp in a buildroot build system. Please, wrap your commit log to about 72 chars. Why does it need to be a static library? Why does a shared library not work? I see tht upstream suggests that, so maybe just state so. > Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com> > --- > package/Config.in | 3 +++ > package/oatpp/Config.in | 14 ++++++++++++++ > package/oatpp/oatpp.mk | 16 ++++++++++++++++ You are missing a hash file, which contains the hashes for the source archive and the license file(s). See below. > diff --git a/package/Config.in b/package/Config.in > index 995dae2c57..481876a278 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1941,6 +1941,7 @@ menu "Networking" > source "package/nss-mdns/Config.in" > source "package/nss-myhostname/Config.in" > source "package/nss-pam-ldapd/Config.in" > + source "package/oatpp/Config.in" > source "package/omniorb/Config.in" > source "package/open-isns/Config.in" > source "package/open62541/Config.in" > @@ -2702,4 +2703,6 @@ menu "Text editors and viewers" > source "package/vim/Config.in" > endmenu > > + > endmenu > + Two spurious empty lines added. > diff --git a/package/oatpp/Config.in b/package/oatpp/Config.in > new file mode 100644 > index 0000000000..86eb4573a6 > --- /dev/null > +++ b/package/oatpp/Config.in > @@ -0,0 +1,14 @@ > +comment "Oat++ needs a toolchain w/ C++, threads and Paranoid Unsafe Path compiler flag disabled" > + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || BR2_COMPILER_PARANOID_UNSAFE_PATH If the paranoid unsafe paths check triggers, it means that the target build is using headers (or libraries) from the host, and that is definitely not correct, as those are not suitable to generate target code. Instead, the package must be fixed. Long-term, we may even make that check mandatory and not configurable, see: http://patchwork.ozlabs.org/project/buildroot/patch/20221107214903.1565321-1-yann.morin.1998@free.fr/ > +config BR2_PACKAGE_OATPP > + bool "Oat++" > + depends on BR2_INSTALL_LIBSTDCPP > + depends on BR2_TOOLCHAIN_HAS_THREADS > + depends on !BR2_COMPILER_PARANOID_UNSAFE_PATH > + help > + Oat++ is an open-source C++ web framework for highly scalable and resource-efficient web applications. > + It provides all the necessary components for production-grade development. > + This package allows you to use oatpp to statically build this a project inside the staging directory. > + See https://oatpp.io/docs/start Help text should be indented with a TAB and two spaces, and wrapped at 72 chars; running "make check-package" will point to coding style issues. > diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk > new file mode 100644 > index 0000000000..7abdeb6de5 > --- /dev/null > +++ b/package/oatpp/oatpp.mk > @@ -0,0 +1,16 @@ > +################################################################################ > +# > +# oatpp > +# > +################################################################################ > + > +OATPP_VERSION= 1.3.0 Spaces around the equal sign; "make check-package" points to it too. > +OATPP_SOURCE= $(OATPP_VERSION).tar.gz > +OATPP_SITE= https://github.com/oatpp/oatpp/archive/refs/tags > +#OATPP_SITE= git://github.com/oatpp/oatpp.git Don't keep commented-out code; just remove it. For github, we have two options: - if the package has been "released" by upstream, then they pushed a tarball and we must use it; - otherwise, we have a macro that assembles a proper URL. In this case, there is no archive published by upstream, so we must use the macro: OATPP_VERSION = 1.3.0 OATPP_SITE = $(call github,oatpp,oatpp,$(OATPP_VERSION)) And that's all (no _SOURCE, no _SITE_METHOD). https://buildroot.org/downloads/manual/manual.html#github-download-url You are also missing the license declaration: OATPP_LICENSE = Apache-2.0 OATPP_LICENSE_FILES = LICENSE > +OATPP_INSTALL_STAGING= YES > +OATPP_INSTALL_TARGET= NO Shy no installation in target? Ah, yes, it's a static lib. Usually, we like a small reminder about that: # Only builds a static lib: OATPP_INSTALL_TARGET= NO > +OATPP_MAKE=make Why do you need to force make? If that's because of a parallel build issue, then use $(MAKE1) instead, and explain it in the commit message. As it is supposed to be a static-only lib (as per upstream suggestion), you probably also need to tell cmake to not build shared libs, which is otherwise what Buildroot enforces: # As per upstream, oat++ is meant to be a static-only lib OATPP_CMAKE_OPTS = -DBUILD_SHARED_LIBS=OFF Can you address those and respin an updated patch, please? Regards, Yann E. MORIN. > +$(eval $(cmake-package)) > + > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/oatpp:: new package 2023-01-28 9:41 [Buildroot] [PATCH 1/1] package/oatpp:: new package Alessandro Partesotti 2023-01-29 17:11 ` Yann E. MORIN @ 2023-01-29 21:32 ` Alessandro Partesotti 2023-01-29 22:50 ` Alessandro Partesotti 2023-01-31 20:00 ` [Buildroot] (no subject) Alessandro Partesotti 3 siblings, 0 replies; 9+ messages in thread From: Alessandro Partesotti @ 2023-01-29 21:32 UTC (permalink / raw) To: buildroot; +Cc: Alessandro Partesotti, Samuel Martin, YANN E . MORIN This package introduce oatpp in BR buildsystem. Oatpp must be used as static library as upstreaam suggest. Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com> --- Changes v1 -> v2 - indentation and spaces (suggested by Yann E. MORIN) - generic macro changes (suggested by Yann E. MORIN) Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com> --- package/Config.in | 1 + package/oatpp/Config.in | 13 +++++++++++++ package/oatpp/oatpp.hash | 2 ++ package/oatpp/oatpp.mk | 16 ++++++++++++++++ 4 files changed, 32 insertions(+) create mode 100644 package/oatpp/Config.in create mode 100644 package/oatpp/oatpp.hash create mode 100644 package/oatpp/oatpp.mk diff --git a/package/Config.in b/package/Config.in index 995dae2c57..c7394ae53d 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1941,6 +1941,7 @@ menu "Networking" source "package/nss-mdns/Config.in" source "package/nss-myhostname/Config.in" source "package/nss-pam-ldapd/Config.in" + source "package/oatpp/Config.in" source "package/omniorb/Config.in" source "package/open-isns/Config.in" source "package/open62541/Config.in" diff --git a/package/oatpp/Config.in b/package/oatpp/Config.in new file mode 100644 index 0000000000..44f0fabed8 --- /dev/null +++ b/package/oatpp/Config.in @@ -0,0 +1,13 @@ +comment "Oat++ needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + +config BR2_PACKAGE_OATPP + bool "Oat++" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_HAS_THREADS + help + Oat++ is an open-source C++ web framework for highly + scalable and resource-efficient web applications. + It provides all the necessary components for + production-grade development. + See https://oatpp.io/docs/start diff --git a/package/oatpp/oatpp.hash b/package/oatpp/oatpp.hash new file mode 100644 index 0000000000..fadea2a05f --- /dev/null +++ b/package/oatpp/oatpp.hash @@ -0,0 +1,2 @@ +# Hash from: https://github.com/oatpp/oatpp/archive/1.3.0/oatpp-1.3.0.tar.gz +sha512 4fe8587efe1b4ecae14554ec8edb209e5558a3e4a4e6ff49bbfaaf06d2cc12f2cc306c5edc43b8dafc465aff53098ad4bebb9971694761b91a553730d5acb59a oatpp-1.3.0.tar.gz diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk new file mode 100644 index 0000000000..d146d05d53 --- /dev/null +++ b/package/oatpp/oatpp.mk @@ -0,0 +1,16 @@ +################################################################################ +# +# oatpp +# +################################################################################ + +OATPP_VERSION = 1.3.0 +OATPP_LICENSE = Apache-2.0 +OATPP_LICENSE_FILES = LICENSE +OATPP_SITE = $(call github,oatpp,oatpp,$(OATPP_VERSION)) +OATPP_CMAKE_OPTS = -DBUILD_SHARED_LIBS=OFF +OATPP_INSTALL_STAGING= YES +# Only builds a static lib: +OATPP_INSTALL_TARGET= NO + +$(eval $(cmake-package)) -- 2.25.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/oatpp:: new package 2023-01-28 9:41 [Buildroot] [PATCH 1/1] package/oatpp:: new package Alessandro Partesotti 2023-01-29 17:11 ` Yann E. MORIN 2023-01-29 21:32 ` [Buildroot] [PATCH v2 " Alessandro Partesotti @ 2023-01-29 22:50 ` Alessandro Partesotti 2023-11-05 20:53 ` Arnout Vandecappelle via buildroot 2023-01-31 20:00 ` [Buildroot] (no subject) Alessandro Partesotti 3 siblings, 1 reply; 9+ messages in thread From: Alessandro Partesotti @ 2023-01-29 22:50 UTC (permalink / raw) To: buildroot; +Cc: Alessandro Partesotti, Samuel Martin, YANN E . MORIN This package introduce oatpp in BR buildsystem. Oatpp must be used as static library as upstreaam suggest. Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com> --- Changes v1 -> v2 - indentation and spaces (suggested by Yann E. MORIN) - generic macro changes (suggested by Yann E. MORIN) Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com> --- DEVELOPERS | 3 +++ package/Config.in | 1 + package/oatpp/Config.in | 13 +++++++++++++ package/oatpp/oatpp.hash | 2 ++ package/oatpp/oatpp.mk | 16 ++++++++++++++++ 5 files changed, 35 insertions(+) create mode 100644 package/oatpp/Config.in create mode 100644 package/oatpp/oatpp.hash create mode 100644 package/oatpp/oatpp.mk diff --git a/DEVELOPERS b/DEVELOPERS index e8e0dffcd3..b2d173dc2e 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -3149,3 +3149,6 @@ F: package/quazip/ F: package/shapelib/ F: package/simple-mail/ F: package/tinc/ + +N: Alessandro Partesotti <a.partesotti@gmail.com> +F: package/oatpp/ diff --git a/package/Config.in b/package/Config.in index 995dae2c57..c7394ae53d 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1941,6 +1941,7 @@ menu "Networking" source "package/nss-mdns/Config.in" source "package/nss-myhostname/Config.in" source "package/nss-pam-ldapd/Config.in" + source "package/oatpp/Config.in" source "package/omniorb/Config.in" source "package/open-isns/Config.in" source "package/open62541/Config.in" diff --git a/package/oatpp/Config.in b/package/oatpp/Config.in new file mode 100644 index 0000000000..44f0fabed8 --- /dev/null +++ b/package/oatpp/Config.in @@ -0,0 +1,13 @@ +comment "Oat++ needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + +config BR2_PACKAGE_OATPP + bool "Oat++" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_HAS_THREADS + help + Oat++ is an open-source C++ web framework for highly + scalable and resource-efficient web applications. + It provides all the necessary components for + production-grade development. + See https://oatpp.io/docs/start diff --git a/package/oatpp/oatpp.hash b/package/oatpp/oatpp.hash new file mode 100644 index 0000000000..fadea2a05f --- /dev/null +++ b/package/oatpp/oatpp.hash @@ -0,0 +1,2 @@ +# Hash from: https://github.com/oatpp/oatpp/archive/1.3.0/oatpp-1.3.0.tar.gz +sha512 4fe8587efe1b4ecae14554ec8edb209e5558a3e4a4e6ff49bbfaaf06d2cc12f2cc306c5edc43b8dafc465aff53098ad4bebb9971694761b91a553730d5acb59a oatpp-1.3.0.tar.gz diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk new file mode 100644 index 0000000000..f949a5cbc9 --- /dev/null +++ b/package/oatpp/oatpp.mk @@ -0,0 +1,16 @@ +################################################################################ +# +# oatpp +# +################################################################################ + +OATPP_VERSION = 1.3.0 +OATPP_LICENSE = Apache-2.0 +OATPP_LICENSE_FILES = LICENSE +OATPP_SITE = $(call github,oatpp,oatpp,$(OATPP_VERSION)) +OATPP_CMAKE_OPTS = -DBUILD_SHARED_LIBS=OFF +OATPP_INSTALL_STAGING = YES +# Only builds a static lib and copy headers: +OATPP_INSTALL_TARGET = NO + +$(eval $(cmake-package)) -- 2.25.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] package/oatpp:: new package 2023-01-29 22:50 ` Alessandro Partesotti @ 2023-11-05 20:53 ` Arnout Vandecappelle via buildroot 0 siblings, 0 replies; 9+ messages in thread From: Arnout Vandecappelle via buildroot @ 2023-11-05 20:53 UTC (permalink / raw) To: Alessandro Partesotti, buildroot; +Cc: YANN E . MORIN Hi Alessandro, I (finally) applied your patch to master, with a whole lot of changes, see below. On 29/01/2023 23:50, Alessandro Partesotti wrote: > This package introduce oatpp in BR buildsystem. This sentence is redundant. > Oatpp must be used as static library as upstreaam suggest. > > Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com> > --- > Changes v1 -> v2 > - indentation and spaces (suggested by Yann E. MORIN) > - generic macro changes (suggested by Yann E. MORIN) > > Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com> > --- > DEVELOPERS | 3 +++ > package/Config.in | 1 + > package/oatpp/Config.in | 13 +++++++++++++ > package/oatpp/oatpp.hash | 2 ++ > package/oatpp/oatpp.mk | 16 ++++++++++++++++ > 5 files changed, 35 insertions(+) > create mode 100644 package/oatpp/Config.in > create mode 100644 package/oatpp/oatpp.hash > create mode 100644 package/oatpp/oatpp.mk > > diff --git a/DEVELOPERS b/DEVELOPERS > index e8e0dffcd3..b2d173dc2e 100644 > --- a/DEVELOPERS > +++ b/DEVELOPERS > @@ -3149,3 +3149,6 @@ F: package/quazip/ > F: package/shapelib/ > F: package/simple-mail/ > F: package/tinc/ > + > +N: Alessandro Partesotti <a.partesotti@gmail.com> DEVELOPERS should be alphabetic by name, so I moved this up. > +F: package/oatpp/ > diff --git a/package/Config.in b/package/Config.in > index 995dae2c57..c7394ae53d 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1941,6 +1941,7 @@ menu "Networking" > source "package/nss-mdns/Config.in" > source "package/nss-myhostname/Config.in" > source "package/nss-pam-ldapd/Config.in" > + source "package/oatpp/Config.in" > source "package/omniorb/Config.in" > source "package/open-isns/Config.in" > source "package/open62541/Config.in" > diff --git a/package/oatpp/Config.in b/package/oatpp/Config.in > new file mode 100644 > index 0000000000..44f0fabed8 > --- /dev/null > +++ b/package/oatpp/Config.in > @@ -0,0 +1,13 @@ > +comment "Oat++ needs a toolchain w/ C++" This was missing threads. > + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS > + > +config BR2_PACKAGE_OATPP > + bool "Oat++" We always use lowercase for the prompts. We also use the package name, unless there is a _very_ good reason to not use it. In this case, upstream seems to use both oat++ and oatpp, so I changed this to oatpp. > + depends on BR2_INSTALL_LIBSTDCPP > + depends on BR2_TOOLCHAIN_HAS_THREADS > + help > + Oat++ is an open-source C++ web framework for highly Now it was wrapped to short :-) > + scalable and resource-efficient web applications. > + It provides all the necessary components for > + production-grade development. > + See https://oatpp.io/docs/start The upstream URL should be on a separate line. > diff --git a/package/oatpp/oatpp.hash b/package/oatpp/oatpp.hash > new file mode 100644 > index 0000000000..fadea2a05f > --- /dev/null > +++ b/package/oatpp/oatpp.hash > @@ -0,0 +1,2 @@ > +# Hash from: https://github.com/oatpp/oatpp/archive/1.3.0/oatpp-1.3.0.tar.gz That's not a hash, that's the tarball itself. There's no upstream hash AFAICS. So I changed this to Locally calculated. > +sha512 4fe8587efe1b4ecae14554ec8edb209e5558a3e4a4e6ff49bbfaaf06d2cc12f2cc306c5edc43b8dafc465aff53098ad4bebb9971694761b91a553730d5acb59a oatpp-1.3.0.tar.gz We use sha256 for locally calculated. There should also be a hash for the license file. > diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk > new file mode 100644 > index 0000000000..f949a5cbc9 > --- /dev/null > +++ b/package/oatpp/oatpp.mk > @@ -0,0 +1,16 @@ > +################################################################################ > +# > +# oatpp > +# > +################################################################################ > + > +OATPP_VERSION = 1.3.0 > +OATPP_LICENSE = Apache-2.0 > +OATPP_LICENSE_FILES = LICENSE > +OATPP_SITE = $(call github,oatpp,oatpp,$(OATPP_VERSION)) > +OATPP_CMAKE_OPTS = -DBUILD_SHARED_LIBS=OFF This should be OATPP_CONF_OPTS, otherwise it isn't used and it does install shared libs... Regards, Arnout > +OATPP_INSTALL_STAGING = YES > +# Only builds a static lib and copy headers: > +OATPP_INSTALL_TARGET = NO > + > +$(eval $(cmake-package)) _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] (no subject) 2023-01-28 9:41 [Buildroot] [PATCH 1/1] package/oatpp:: new package Alessandro Partesotti ` (2 preceding siblings ...) 2023-01-29 22:50 ` Alessandro Partesotti @ 2023-01-31 20:00 ` Alessandro Partesotti 3 siblings, 0 replies; 9+ messages in thread From: Alessandro Partesotti @ 2023-01-31 20:00 UTC (permalink / raw) To: buildroot; +Cc: Samuel Martin, YANN E . MORIN Subject: [PATCH 1/1] package/oatpp:: new package Hi Yann , All I've resubmitted the patch with the requested changes. Thank you for your time https://patchwork.ozlabs.org/project/buildroot/patch/20230129225000.336472-1-a.partesotti@gmail.com/ Regards Alesaadnro Partesotti _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/oatpp:: new package @ 2023-01-27 23:18 Alessandro Partesotti 2023-01-28 0:17 ` bryce.schober 0 siblings, 1 reply; 9+ messages in thread From: Alessandro Partesotti @ 2023-01-27 23:18 UTC (permalink / raw) To: buildroot; +Cc: Alessandro Partesotti, Samuel Martin This package introduce oatpp in BR buildsystem. oatpp must be used as static linkable library in $(STAGING_DIR)/usr/include/oatpp-$(OATPP_VERSION)/oatpp for user that want to build therir own application by linking oatpp in a buildroot build system. Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com> --- package/Config.in | 3 +++ package/oatpp/Config.in | 14 ++++++++++++++ package/oatpp/oatpp.mk | 16 ++++++++++++++++ 3 files changed, 33 insertions(+) create mode 100644 package/oatpp/Config.in create mode 100644 package/oatpp/oatpp.mk diff --git a/package/Config.in b/package/Config.in index 995dae2c57..481876a278 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1941,6 +1941,7 @@ menu "Networking" source "package/nss-mdns/Config.in" source "package/nss-myhostname/Config.in" source "package/nss-pam-ldapd/Config.in" + source "package/oatpp/Config.in" source "package/omniorb/Config.in" source "package/open-isns/Config.in" source "package/open62541/Config.in" @@ -2702,4 +2703,6 @@ menu "Text editors and viewers" source "package/vim/Config.in" endmenu + endmenu + diff --git a/package/oatpp/Config.in b/package/oatpp/Config.in new file mode 100644 index 0000000000..3cf6bf3ef5 --- /dev/null +++ b/package/oatpp/Config.in @@ -0,0 +1,14 @@ +comment "Oat++ needs a toolchain w/ C++, threads and Paranoid Unsafe Path compiler flag disabled" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || BR2_COMPILER_PARANOID_UNSAFE_PATH + +config BR2_PACKAGE_OATPP + bool "Oat++" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_COMPILER_PARANOID_UNSAFE_PATH + help + Oat++ is an open-source C++ web framework for highly scalable and resource-efficient web applications. + It provides all the necessary components for production-grade development. + This package allows you to use oatpp to statically build this a project inside the staging directory. + See https://oatpp.io/docs/ + diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk new file mode 100644 index 0000000000..7abdeb6de5 --- /dev/null +++ b/package/oatpp/oatpp.mk @@ -0,0 +1,16 @@ +################################################################################ +# +# oatpp +# +################################################################################ + +OATPP_VERSION= 1.3.0 +OATPP_SOURCE= $(OATPP_VERSION).tar.gz +OATPP_SITE= https://github.com/oatpp/oatpp/archive/refs/tags +#OATPP_SITE= git://github.com/oatpp/oatpp.git +OATPP_INSTALL_STAGING= YES +OATPP_INSTALL_TARGET= NO +OATPP_MAKE=make + +$(eval $(cmake-package)) + -- 2.25.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/oatpp:: new package 2023-01-27 23:18 [Buildroot] [PATCH 1/1] package/oatpp:: new package Alessandro Partesotti @ 2023-01-28 0:17 ` bryce.schober 2023-01-28 9:45 ` Alessandro Partesotti 0 siblings, 1 reply; 9+ messages in thread From: bryce.schober @ 2023-01-28 0:17 UTC (permalink / raw) To: Alessandro Partesotti; +Cc: Samuel Martin, buildroot [-- Attachment #1.1: Type: text/plain, Size: 3429 bytes --] For https://oatpp.io/docs/, I get: server=oatpp/1.3.0 code=500 description=Internal Server Error message=Page not found It looks like it doesn't like trimming the URL, and https://oatpp.io/docs/start looks better. <>< <>< <>< Bryce Schober On Fri, Jan 27, 2023 at 3:18 PM Alessandro Partesotti < a.partesotti@gmail.com> wrote: > This package introduce oatpp in BR buildsystem. oatpp must be used as > static linkable library in > $(STAGING_DIR)/usr/include/oatpp-$(OATPP_VERSION)/oatpp for user that want > to build therir own application by linking oatpp in a buildroot build > system. > > Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com> > --- > package/Config.in | 3 +++ > package/oatpp/Config.in | 14 ++++++++++++++ > package/oatpp/oatpp.mk | 16 ++++++++++++++++ > 3 files changed, 33 insertions(+) > create mode 100644 package/oatpp/Config.in > create mode 100644 package/oatpp/oatpp.mk > > diff --git a/package/Config.in b/package/Config.in > index 995dae2c57..481876a278 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1941,6 +1941,7 @@ menu "Networking" > source "package/nss-mdns/Config.in" > source "package/nss-myhostname/Config.in" > source "package/nss-pam-ldapd/Config.in" > + source "package/oatpp/Config.in" > source "package/omniorb/Config.in" > source "package/open-isns/Config.in" > source "package/open62541/Config.in" > @@ -2702,4 +2703,6 @@ menu "Text editors and viewers" > source "package/vim/Config.in" > endmenu > > + > endmenu > + > diff --git a/package/oatpp/Config.in b/package/oatpp/Config.in > new file mode 100644 > index 0000000000..3cf6bf3ef5 > --- /dev/null > +++ b/package/oatpp/Config.in > @@ -0,0 +1,14 @@ > +comment "Oat++ needs a toolchain w/ C++, threads and Paranoid Unsafe Path > compiler flag disabled" > + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS > || BR2_COMPILER_PARANOID_UNSAFE_PATH > + > +config BR2_PACKAGE_OATPP > + bool "Oat++" > + depends on BR2_INSTALL_LIBSTDCPP > + depends on BR2_TOOLCHAIN_HAS_THREADS > + depends on !BR2_COMPILER_PARANOID_UNSAFE_PATH > + help > + Oat++ is an open-source C++ web framework for highly > scalable and resource-efficient web applications. > + It provides all the necessary components for > production-grade development. > + This package allows you to use oatpp to statically build > this a project inside the staging directory. > + See https://oatpp.io/docs/ > + > diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk > new file mode 100644 > index 0000000000..7abdeb6de5 > --- /dev/null > +++ b/package/oatpp/oatpp.mk > @@ -0,0 +1,16 @@ > > +################################################################################ > +# > +# oatpp > +# > > +################################################################################ > + > +OATPP_VERSION= 1.3.0 > +OATPP_SOURCE= $(OATPP_VERSION).tar.gz > +OATPP_SITE= https://github.com/oatpp/oatpp/archive/refs/tags > +#OATPP_SITE= git://github.com/oatpp/oatpp.git > +OATPP_INSTALL_STAGING= YES > +OATPP_INSTALL_TARGET= NO > +OATPP_MAKE=make > + > +$(eval $(cmake-package)) > + > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot > [-- Attachment #1.2: Type: text/html, Size: 5342 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/oatpp:: new package 2023-01-28 0:17 ` bryce.schober @ 2023-01-28 9:45 ` Alessandro Partesotti 0 siblings, 0 replies; 9+ messages in thread From: Alessandro Partesotti @ 2023-01-28 9:45 UTC (permalink / raw) To: bryce.schober; +Cc: Samuel Martin, buildroot [-- Attachment #1.1.1: Type: text/plain, Size: 3711 bytes --] Fixed! but maybe i made i mistake by submitting a new patch [image: image.png] Il giorno sab 28 gen 2023 alle ore 01:17 <bryce.schober@gmail.com> ha scritto: > For https://oatpp.io/docs/, I get: > > server=oatpp/1.3.0 > code=500 > description=Internal Server Error > message=Page not found > > It looks like it doesn't like trimming the URL, and > https://oatpp.io/docs/start looks better. > > <>< <>< <>< > Bryce Schober > > > On Fri, Jan 27, 2023 at 3:18 PM Alessandro Partesotti < > a.partesotti@gmail.com> wrote: > >> This package introduce oatpp in BR buildsystem. oatpp must be used as >> static linkable library in >> $(STAGING_DIR)/usr/include/oatpp-$(OATPP_VERSION)/oatpp for user that want >> to build therir own application by linking oatpp in a buildroot build >> system. >> >> Signed-off-by: Alessandro Partesotti <a.partesotti@gmail.com> >> --- >> package/Config.in | 3 +++ >> package/oatpp/Config.in | 14 ++++++++++++++ >> package/oatpp/oatpp.mk | 16 ++++++++++++++++ >> 3 files changed, 33 insertions(+) >> create mode 100644 package/oatpp/Config.in >> create mode 100644 package/oatpp/oatpp.mk >> >> diff --git a/package/Config.in b/package/Config.in >> index 995dae2c57..481876a278 100644 >> --- a/package/Config.in >> +++ b/package/Config.in >> @@ -1941,6 +1941,7 @@ menu "Networking" >> source "package/nss-mdns/Config.in" >> source "package/nss-myhostname/Config.in" >> source "package/nss-pam-ldapd/Config.in" >> + source "package/oatpp/Config.in" >> source "package/omniorb/Config.in" >> source "package/open-isns/Config.in" >> source "package/open62541/Config.in" >> @@ -2702,4 +2703,6 @@ menu "Text editors and viewers" >> source "package/vim/Config.in" >> endmenu >> >> + >> endmenu >> + >> diff --git a/package/oatpp/Config.in b/package/oatpp/Config.in >> new file mode 100644 >> index 0000000000..3cf6bf3ef5 >> --- /dev/null >> +++ b/package/oatpp/Config.in >> @@ -0,0 +1,14 @@ >> +comment "Oat++ needs a toolchain w/ C++, threads and Paranoid Unsafe >> Path compiler flag disabled" >> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS >> || BR2_COMPILER_PARANOID_UNSAFE_PATH >> + >> +config BR2_PACKAGE_OATPP >> + bool "Oat++" >> + depends on BR2_INSTALL_LIBSTDCPP >> + depends on BR2_TOOLCHAIN_HAS_THREADS >> + depends on !BR2_COMPILER_PARANOID_UNSAFE_PATH >> + help >> + Oat++ is an open-source C++ web framework for highly >> scalable and resource-efficient web applications. >> + It provides all the necessary components for >> production-grade development. >> + This package allows you to use oatpp to statically build >> this a project inside the staging directory. >> + See https://oatpp.io/docs/ >> + >> diff --git a/package/oatpp/oatpp.mk b/package/oatpp/oatpp.mk >> new file mode 100644 >> index 0000000000..7abdeb6de5 >> --- /dev/null >> +++ b/package/oatpp/oatpp.mk >> @@ -0,0 +1,16 @@ >> >> +################################################################################ >> +# >> +# oatpp >> +# >> >> +################################################################################ >> + >> +OATPP_VERSION= 1.3.0 >> +OATPP_SOURCE= $(OATPP_VERSION).tar.gz >> +OATPP_SITE= https://github.com/oatpp/oatpp/archive/refs/tags >> +#OATPP_SITE= git://github.com/oatpp/oatpp.git >> +OATPP_INSTALL_STAGING= YES >> +OATPP_INSTALL_TARGET= NO >> +OATPP_MAKE=make >> + >> +$(eval $(cmake-package)) >> + >> -- >> 2.25.1 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot >> > [-- Attachment #1.1.2: Type: text/html, Size: 5878 bytes --] [-- Attachment #1.2: image.png --] [-- Type: image/png, Size: 69867 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-11-05 20:53 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-28 9:41 [Buildroot] [PATCH 1/1] package/oatpp:: new package Alessandro Partesotti 2023-01-29 17:11 ` Yann E. MORIN 2023-01-29 21:32 ` [Buildroot] [PATCH v2 " Alessandro Partesotti 2023-01-29 22:50 ` Alessandro Partesotti 2023-11-05 20:53 ` Arnout Vandecappelle via buildroot 2023-01-31 20:00 ` [Buildroot] (no subject) Alessandro Partesotti -- strict thread matches above, loose matches on Subject: below -- 2023-01-27 23:18 [Buildroot] [PATCH 1/1] package/oatpp:: new package Alessandro Partesotti 2023-01-28 0:17 ` bryce.schober 2023-01-28 9:45 ` Alessandro Partesotti
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
![[-- Attachment #1.2: image.png --] [-- Type: image/png, Size: 69867 bytes --]](../../CABPCGC+ZAepPOQzU4KP8gNe=SmJTHGqv9jdXQ7J2RH-VeiNVJg@mail.gmail.com/1.2-image.png){kind=link}