Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Stefan Hager <stefan.hager@ginzinger.com>,
	Samuel Martin <s.martin49@gmail.com>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4 01/13] package/flatbuffers: build position independent code
Date: Sun, 29 Jan 2023 21:55:09 +0100	[thread overview]
Message-ID: <20230129205509.GW2632@scaer> (raw)
In-Reply-To: <20230127141058.2180747-1-james.hilliard1@gmail.com>

James, All,

On 2023-01-27 07:10 -0700, James Hilliard spake thusly:
> The upcoming tensorflow-lite package requires flatbuffers to be
> built with position independent code.
> 
> Fixes:
> /home/buildroot/buildroot/output/per-package/tensorflow-lite/host/bin/../lib/gcc/aarch64-buildroot-linux-gnu/11.3.0/../../../../aarch64-buildroot-linux-gnu/bin/ld: /home/buildroot/buildroot/output/per-package/tensorflow-lite/host/aarch64-buildroot-linux-gnu/sysroot/usr/lib/libflatbuffers.a(util.cpp.o): relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `_ZN11flatbuffers11CharToUpperEc' which may bind externally can not be used when making a shared object; recompile with -fPIC
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/flatbuffers/flatbuffers.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/flatbuffers/flatbuffers.mk b/package/flatbuffers/flatbuffers.mk
> index 9d286bf9e1..487d85ee1f 100644
> --- a/package/flatbuffers/flatbuffers.mk
> +++ b/package/flatbuffers/flatbuffers.mk
> @@ -14,6 +14,7 @@ FLATBUFFERS_DEPENDENCIES = host-flatbuffers
>  
>  FLATBUFFERS_CONF_OPTS += \
>  	-DCMAKE_CXX_FLAGS="-std=c++11" \
> +	-DCMAKE_POSITION_INDEPENDENT_CODE=ON \
>  	-DFLATBUFFERS_BUILD_TESTS=OFF \
>  	-DFLATBUFFERS_FLATC_EXECUTABLE=$(HOST_DIR)/bin/flatc
>  
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2023-01-29 20:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 14:10 [Buildroot] [PATCH v4 01/13] package/flatbuffers: build position independent code James Hilliard
2023-01-27 14:10 ` [Buildroot] [PATCH v4 02/13] package/cpuinfo: new package James Hilliard
2023-01-29 21:18   ` Yann E. MORIN
2023-01-27 14:10 ` [Buildroot] [PATCH v4 03/13] package/ruy: " James Hilliard
2023-01-27 14:10 ` [Buildroot] [PATCH v4 04/13] package/gemmlowp: " James Hilliard
2023-01-29 21:45   ` Yann E. MORIN
2023-01-30  3:17     ` James Hilliard
2023-01-30  7:13       ` Yann E. MORIN
2023-01-30  7:45         ` James Hilliard
2023-01-29 21:46   ` Yann E. MORIN
2023-01-29 23:51     ` James Hilliard
2023-01-27 14:10 ` [Buildroot] [PATCH v4 05/13] package/neon-2-sse: " James Hilliard
2023-01-29 21:58   ` Yann E. MORIN
2023-01-27 14:10 ` [Buildroot] [PATCH v4 06/13] package/fxdiv: " James Hilliard
2023-01-29 22:28   ` Yann E. MORIN
2023-01-27 14:10 ` [Buildroot] [PATCH v4 07/13] package/pthreadpool: " James Hilliard
2023-01-27 14:10 ` [Buildroot] [PATCH v4 08/13] package/psimd: " James Hilliard
2023-01-27 14:10 ` [Buildroot] [PATCH v4 09/13] package/fp16: " James Hilliard
2023-01-27 14:10 ` [Buildroot] [PATCH v4 10/13] package/xnnpack: " James Hilliard
2023-01-27 14:10 ` [Buildroot] [PATCH v4 11/13] package/fft2d: " James Hilliard
2023-01-27 14:10 ` [Buildroot] [PATCH v4 12/13] package/farmhash: " James Hilliard
2023-01-27 14:10 ` [Buildroot] [PATCH v4 13/13] package/tensorflow-lite: " James Hilliard
2023-01-29 20:55 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230129205509.GW2632@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=s.martin49@gmail.com \
    --cc=stefan.hager@ginzinger.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox