Re: [Buildroot] [PATCH v4 02/13] package/cpuinfo: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

James, All,

On 2023-01-27 07:10 -0700, James Hilliard spake thusly:
> From: Stefan Hager <stefan.hager@ginzinger.com>
> 
> This package is required by tensorflow-lite.
> 
> Tested-by: Stefan Hager <stefan.hager@ginzinger.com>
> Signed-off-by: Stefan Hager <stefan.hager@ginzinger.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/cpuinfo/Config.in b/package/cpuinfo/Config.in
> new file mode 100644
> index 0000000000..137f657d69
> --- /dev/null
> +++ b/package/cpuinfo/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_CPUINFO
> +	bool "cpuinfo"
> +	depends on BR2_INSTALL_LIBSTDCPP

The CMakeList.txt requires a CXX compiler but it looks like cpuinfo is a
C-only package, as I could not find any C++ source file, except some
test cases, and the benchmarks but they are disabled.

So, I think we should make C++ optional and submit the patch upstream.

Regards,
Yann E. MORIN.

> +	help
> +	  CPU INFOrmation library, cpuinfo is a library to detect
> +	  essential for performance optimization information about
> +	  host CPU.
> +
> +	  https://github.com/pytorch/cpuinfo
> diff --git a/package/cpuinfo/cpuinfo.hash b/package/cpuinfo/cpuinfo.hash
> new file mode 100644
> index 0000000000..c3f70fa90f
> --- /dev/null
> +++ b/package/cpuinfo/cpuinfo.hash
> @@ -0,0 +1,4 @@
> +# Locally calculated
> +sha256  0936848904943381b2c01321101614776e43d583840ee0f3ceeea1e3fb7405f7  cpuinfo-de2fa78ebb431db98489e78603e4f77c1f6c5c57.tar.gz
> +# License files, locally calculated
> +sha256  8e7e60636c3aa0cb03571a1a841ce5697f9551ff92b3c426c2561613d15ade70  LICENSE
> diff --git a/package/cpuinfo/cpuinfo.mk b/package/cpuinfo/cpuinfo.mk
> new file mode 100644
> index 0000000000..ab6a0269ec
> --- /dev/null
> +++ b/package/cpuinfo/cpuinfo.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# cpuinfo
> +#
> +################################################################################
> +
> +CPUINFO_VERSION = de2fa78ebb431db98489e78603e4f77c1f6c5c57
> +CPUINFO_SITE = $(call github,pytorch,cpuinfo,$(CPUINFO_VERSION))
> +CPUINFO_LICENSE = BSD-2-Clause
> +CPUINFO_LICENSE_FILES = LICENSE
> +CPUINFO_INSTALL_STAGING = YES
> +CPUINFO_CONF_OPTS = \
> +	-DCPUINFO_BUILD_UNIT_TESTS=OFF \
> +	-DCPUINFO_BUILD_MOCK_TESTS=OFF \
> +	-DCPUINFO_BUILD_BENCHMARKS=OFF
> +
> +$(eval $(cmake-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot