* [Buildroot] [PATCH v1 1/1] board/versal/post-image.sh: do not require xilinx/ prefix for .dts files
@ 2023-02-02 13:38 Neal Frager via buildroot
2023-02-03 7:47 ` Luca Ceresoli via buildroot
2023-02-05 12:24 ` Thomas Petazzoni via buildroot
0 siblings, 2 replies; 3+ messages in thread
From: Neal Frager via buildroot @ 2023-02-02 13:38 UTC (permalink / raw)
To: buildroot
Cc: ibai.erkiaga-elorza, luca.ceresoli, gsmecher, thomas.petazzoni,
Neal Frager, michal.simek
If using BR2_LINUX_KERNEL_CUSTOM_DTS_PATH to copy .dts files from
buildroot into the linux tree, these .dts files are copied to
arch/arm64/boot. Unfortunately, the post-image.sh script expects to find
them in arch/arm64/boot/xilinx.
This patch does not require the xilinx/ prefix to be present when
symlinking the device-tree to system.dtb where u-boot expects to find
it.
It is effectively applying the below patch for zynqmp to versal as well:
https://patchwork.ozlabs.org/project/buildroot/patch/20230201195956.1758827-1-gsmecher@threespeedlogic.com/
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
board/versal/post-image.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/versal/post-image.sh b/board/versal/post-image.sh
index f45f29a155..92e65ed3b7 100755
--- a/board/versal/post-image.sh
+++ b/board/versal/post-image.sh
@@ -5,7 +5,7 @@
# devicetree listed in the config.
FIRST_DT=$(sed -nr \
- -e 's|^BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/([-_/[:alnum:]\\.]*).*"$|\1|p' \
+ -e 's|^BR2_LINUX_KERNEL_INTREE_DTS_NAME="(xilinx/)?([-_/[:alnum:]\\.]*).*"$|\2|p' \
${BR2_CONFIG})
[ -z "${FIRST_DT}" ] || ln -fs ${FIRST_DT}.dtb ${BINARIES_DIR}/system.dtb
--
2.17.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] board/versal/post-image.sh: do not require xilinx/ prefix for .dts files
2023-02-02 13:38 [Buildroot] [PATCH v1 1/1] board/versal/post-image.sh: do not require xilinx/ prefix for .dts files Neal Frager via buildroot
@ 2023-02-03 7:47 ` Luca Ceresoli via buildroot
2023-02-05 12:24 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Luca Ceresoli via buildroot @ 2023-02-03 7:47 UTC (permalink / raw)
To: Neal Frager
Cc: ibai.erkiaga-elorza, gsmecher, thomas.petazzoni, buildroot,
michal.simek
Hi Neal,
On Thu, 2 Feb 2023 13:38:17 +0000
Neal Frager <neal.frager@amd.com> wrote:
> If using BR2_LINUX_KERNEL_CUSTOM_DTS_PATH to copy .dts files from
> buildroot into the linux tree, these .dts files are copied to
> arch/arm64/boot. Unfortunately, the post-image.sh script expects to find
> them in arch/arm64/boot/xilinx.
>
> This patch does not require the xilinx/ prefix to be present when
> symlinking the device-tree to system.dtb where u-boot expects to find
> it.
>
> It is effectively applying the below patch for zynqmp to versal as well:
> https://patchwork.ozlabs.org/project/buildroot/patch/20230201195956.1758827-1-gsmecher@threespeedlogic.com/
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> board/versal/post-image.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/versal/post-image.sh b/board/versal/post-image.sh
> index f45f29a155..92e65ed3b7 100755
> --- a/board/versal/post-image.sh
> +++ b/board/versal/post-image.sh
> @@ -5,7 +5,7 @@
> # devicetree listed in the config.
>
> FIRST_DT=$(sed -nr \
> - -e 's|^BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/([-_/[:alnum:]\\.]*).*"$|\1|p' \
> + -e 's|^BR2_LINUX_KERNEL_INTREE_DTS_NAME="(xilinx/)?([-_/[:alnum:]\\.]*).*"$|\2|p' \
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v1 1/1] board/versal/post-image.sh: do not require xilinx/ prefix for .dts files
2023-02-02 13:38 [Buildroot] [PATCH v1 1/1] board/versal/post-image.sh: do not require xilinx/ prefix for .dts files Neal Frager via buildroot
2023-02-03 7:47 ` Luca Ceresoli via buildroot
@ 2023-02-05 12:24 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-05 12:24 UTC (permalink / raw)
To: Neal Frager via buildroot
Cc: michal.simek, gsmecher, ibai.erkiaga-elorza, luca.ceresoli,
Neal Frager
On Thu, 2 Feb 2023 13:38:17 +0000
Neal Frager via buildroot <buildroot@buildroot.org> wrote:
> If using BR2_LINUX_KERNEL_CUSTOM_DTS_PATH to copy .dts files from
> buildroot into the linux tree, these .dts files are copied to
> arch/arm64/boot. Unfortunately, the post-image.sh script expects to find
> them in arch/arm64/boot/xilinx.
>
> This patch does not require the xilinx/ prefix to be present when
> symlinking the device-tree to system.dtb where u-boot expects to find
> it.
>
> It is effectively applying the below patch for zynqmp to versal as well:
> https://patchwork.ozlabs.org/project/buildroot/patch/20230201195956.1758827-1-gsmecher@threespeedlogic.com/
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> board/versal/post-image.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-05 12:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-02 13:38 [Buildroot] [PATCH v1 1/1] board/versal/post-image.sh: do not require xilinx/ prefix for .dts files Neal Frager via buildroot
2023-02-03 7:47 ` Luca Ceresoli via buildroot
2023-02-05 12:24 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox