Re: [Buildroot] [PATCH] toolchain-external: handle case of dangling symlink

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Fri, 24 Jun 2022 15:19:01 -0700
Markus Mayer via buildroot <buildroot@buildroot.org> wrote:

> copy_toolchain_lib_root was not handling the case of "readlink"
> returning nothing, which will happen if the symlink it is trying to
> resolve does not point to a valid file on the build host. This
> shouldn't happen, but it can.
> 
> The end result of this situation would be an endless loop of error
> messages that would only end if aborted manually.
> 
>     [...]
>     cp: missing destination file operand after
>     '/local/users/mmayer/buildroot/output/arm64/target//'
>     Try 'cp --help' for more information.
>     readlink: missing operand
>     Try 'readlink --help' for more information.
>     basename: missing operand
>     Try 'basename --help' for more information.
>     dirname: missing operand
>     Try 'dirname --help' for more information.
>     ^C
>     make[1]: *** [package/pkg-generic.mk:384:
> 
> Instead of looping endlessly without explanation, let's abort and
> inform the user that something seems amiss with their setup.
> 
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
>  toolchain/helpers.mk | 5 +++++
>  1 file changed, 5 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot