Re: [Buildroot] [PATCH] toolchain-external: handle case of dangling symlink

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Romain,

On Wed, 11 Jan 2023 15:47:50 +0100
Romain Naour <romain.naour@smile.fr> wrote:

> > +				if [ "$${LIBPATH}" = "" ]; then \
> > +					echo "LIBPATH empty after trying to resolve symlink $${OLD_LIBPATH}" 1>&2; \
> > +					exit 1; \
> > +				fi; \  
> 
> I'm not sure it's ok to fail here on a dangling symlink.
> Maybe add a check and ignore such dangling symlink with a warning for the user.
> 
> It's unlikely that such dangling symlink provided by the toolchain will be useful.

I hesitated a bit on this. But for now, I believe a toolchain with a
dangling symlink is badly broken, and we should not work with it. A
warning message with a build continuing will never be noticed by the
user, so if we don't abort with hard error, nobody will notice. So I
applied the patch of Markus as is for now.

We will see if people complain that this breaks with their toolchain,
and if it does, we will change the exit to a break to simply move on to
handle the next library.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot